HBASE-28150 CreateTableProcedure and DeleteTableProcedure should slee… #5502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Nov 4, 2023
| long sleepTime = retryCounter.getBackoffTimeAndIncrementAttempts(); | ||
| LOG.warn("Retriable error trying to delete table=" + getTableName() + " state=" + state | ||
| + ", Will sleep " + sleepTime / 1000 + " secs and try again later", e); | ||
| Threads.sleep(sleepTime); |
There was a problem hiding this comment.
Better not sleep directly here as it will block e PEWorker. You can call suspend method from the parent Procedure class to suspend the procedure for a while.
And we also need to reset the retryCounter if there is no problem after retrying.
There was a problem hiding this comment.
thanks for reviwing
- i have some questions...
you suggest call suspend method from the parent Procedure?
but CreateTableProcedure did not have a parent proc, or you mean we need add a suspent method to
AbstractStateMachineTableProcedure?
For the old logic, TRSP could suspent, but CreateTableProcedure could not..
2.yeah, we need reset the retryCounter...
There was a problem hiding this comment.
The suspend method is in the Procedure class, which is the parent class for all procedures.
There was a problem hiding this comment.
Check out #5534 for a recent example of doing this pausing
|
Any updates here? |
|
Ping @chaijunjie0101 |
i am so sorry, i forget it... i will fix it as soon as possible. |
chaijunjie0101
force-pushed
the
HBASE-28150
branch
3 times, most recently
from
db20f6a to
da1cc82
Compare
|
@bbeaudreault thanks for suggestting |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The 2 failed UT seems not related to this MR |
Apache9
reviewed
Apr 17, 2024
| long backoff = retryCounter.getBackoffTimeAndIncrementAttempts(); | ||
| LOG.warn("Retriable error trying to create table={},state={},suspend {}secs.", | ||
| getTableName(), state, backoff / 1000, e); | ||
| throw suspend(Math.toIntExact(backoff), true); | ||
| } | ||
| } | ||
| return Flow.HAS_MORE_STATE; |
There was a problem hiding this comment.
You need to reset the retryCounter to null here. The reason for resetting is that, if we have successfully finished one step, we should reset the retryCounter.
| long backoff = retryCounter.getBackoffTimeAndIncrementAttempts(); | ||
| LOG.warn("Retriable error trying to delete table={},state={},suspend {}secs.", | ||
| getTableName(), state, backoff / 1000, e); | ||
| throw suspend(Math.toIntExact(backoff), true); | ||
| } | ||
| } | ||
| return Flow.HAS_MORE_STATE; |
…p a while before retrying
chaijunjie0101
force-pushed
the
HBASE-28150
branch
from
da1cc82 to
8735bb8
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Apr 21, 2024
Apache9
pushed a commit
that referenced
this pull request
Apr 21, 2024
…p a while before retrying (#5502) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit aaeef2d)
Apache9
pushed a commit
that referenced
this pull request
Apr 21, 2024
…p a while before retrying (#5502) Signed-off-by: Duo Zhang <[email protected]>
Apache9
pushed a commit
that referenced
this pull request
Apr 21, 2024
…p a while before retrying (#5502) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 5a404c4)
mnpoonia
pushed a commit
to mnpoonia/hbase
that referenced
this pull request
Apr 24, 2024
…p a while before retrying (apache#5502) Signed-off-by: Duo Zhang <[email protected]>
mnpoonia
pushed a commit
to mnpoonia/hbase
that referenced
this pull request
Apr 24, 2024
…uld sleep a while before retrying (apache#5502)" This reverts commit aaeef2d.
mnpoonia
pushed a commit
to mnpoonia/hbase
that referenced
this pull request
Apr 24, 2024
…p a while before retrying (apache#5502) Signed-off-by: Duo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p a while before retrying