HBASE-22930 Set unique name to longCompactions/shortCompactions threads #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
reviewed
Sep 3, 2019
| new ThreadPoolExecutor(largeThreads, largeThreads, 60, TimeUnit.SECONDS, stealJobQueue, | ||
| new ThreadFactoryBuilder().setNameFormat(n + "-longCompactions-" | ||
| + longCompactionThreadCounter.getAndIncrement() + "-" + System.currentTimeMillis()) | ||
| .setDaemon(true).build()); |
There was a problem hiding this comment.
Does this work @pankaj72981 ? Each time we create a new thread in ThreadPoolExecutor, does the local longCompactionThreadCounter get a #getAndIncrement call so each thread gets an id? If so, do we need the System.currentTimeMillis thing?
There was a problem hiding this comment.
Thanks @saintstack Sir for looking into this issue.
Each time we create a new thread in ThreadPoolExecutor, does the local longCompactionThreadCounter get a #getAndIncrement call so each thread gets an id?
longCompactionThreadCounter works properly, each thread will have incremented ID.
do we need the System.currentTimeMillis thing?
Not so much required, will be better to have.
| this.shortCompactions = new ThreadPoolExecutor(smallThreads, smallThreads, 60, TimeUnit.SECONDS, | ||
| stealJobQueue.getStealFromQueue(), | ||
| new ThreadFactoryBuilder().setNameFormat(n + "-shortCompactions-" | ||
| + shortCompactionThreadCounter.getAndIncrement() + "-" + System.currentTimeMillis()) |
There was a problem hiding this comment.
Does the 'n' have a thread number in it? If so, do we need this AtomicInteger? Drop the currentTimeMillis and counter and just decorate with -short or -long compaction addition?
There was a problem hiding this comment.
Does the 'n' have a thread number in it?
No, it will be just RS name/ip-port.
May be you can have a look into below discussion,
https://issues.apache.org/jira/browse/HBASE-22930?focusedCommentId=16922548&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16922548
|
Sorry @pankaj72981 I'm figuring that I do reviews but forget to do the 'submit' step so you don't see them.. they just hang out. My fault. |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…ns threads (apache#548)" This reverts commit d3cb7b4.
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…ds (apache#548) (cherry picked from commit d3cb7b4) Change-Id: Ibe941d57377a84847c2a85048742c7e523b8de08
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…ns threads (apache#548)" This reverts commit d3cb7b4. (cherry picked from commit 6a778b8) Change-Id: I8f05d4e8aebe5e2f94ca982a53dd46102ccc0f26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appended the counter in the thread name.