-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28017: set request and response sizes in NettyRpcDuplexHandler #5473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
Oct 24, 2023
bbeaudreault
approved these changes
Oct 24, 2023
bbeaudreault
pushed a commit
that referenced
this pull request
Oct 24, 2023
…ndler (#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
bbeaudreault
pushed a commit
that referenced
this pull request
Oct 24, 2023
…ndler (#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
bbeaudreault
pushed a commit
that referenced
this pull request
Oct 24, 2023
…ndler (#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
bbeaudreault
pushed a commit
to HubSpot/hbase
that referenced
this pull request
Oct 24, 2023
…n NettyRpcDuplexHandler (apache#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
nikita15p
pushed a commit
to nikita15p/hbase
that referenced
this pull request
Oct 29, 2023
…ndler (apache#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Nov 2, 2023
…ndler (apache#5473) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-28017
These new calls have equivalents in BlockingRpcConnection's read/write methods. This will ensure that request/response size metrics are available to those using the netty client.
cc @bbeaudreault @hgromer @eab148 @bozzkar