-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28138 Make the connection idle timeout configurable for the embedded HTTP servers #5457
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a nit comment regarding variable naming.
Also, I have changed the jira/PR description in order to better reflect what this PR is actually doing.
@@ -115,6 +115,11 @@ public class HttpServer implements FilterContainer { | |||
// limitation otherwise the UTs will fail | |||
private static final int DEFAULT_MAX_HEADER_SIZE = Character.MAX_VALUE - 1; | |||
|
|||
//Add configuration for jetty idle timeout | |||
private static final String HTTP_JETTY_IDLE_TIMEOUT = "hbase.master.ui.connection.idleTimeout"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this property actually affects all processes that run an http server, not only the master UI. So we should name it accordingly.
…edded HTTP servers
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…edded HTTP servers (#5457) Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from 8a9ad07)
…edded HTTP servers (#5457) Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 8a9ad07)
…edded HTTP servers (apache#5457) Signed-off-by: Wellington Chevreuil <[email protected]>
No description provided.