HBASE-28106 TestShadeSaslAuthenticationProvider fails for branch-2.x #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
NihalJain
reviewed
Sep 24, 2023
| t.get(new Get(Bytes.toBytes("r1"))); | ||
| fail("Should not successfully authenticate with HBase"); | ||
| return null; | ||
| // Server will close the connection directly once auth failed, so at client side, we do not |
There was a problem hiding this comment.
nit: we could add another test for HBase Master API here similar to how it is done in master branch. Could be done as another JIRA also or you could add in current itself.
The following code works:
@Test public void testNegativeAuthentication() throws Exception {
// Validate that we can read that record back out as the user with our custom auth'n
final Configuration clientConf = new Configuration(CONF);
clientConf.setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 3);
try (Connection conn = ConnectionFactory.createConnection(clientConf)) {
UserGroupInformation user1 =
UserGroupInformation.createUserForTesting("user1", new String[0]);
user1.addToken(
ShadeClientTokenUtil.obtainToken(conn, "user1", "not a real password".toCharArray()));
LOG.info("Executing request to HBase Master which should fail");
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
try (Connection conn = ConnectionFactory.createConnection(clientConf);) {
conn.getAdmin().listTableDescriptors();
fail("Should not successfully authenticate with HBase");
} catch (Exception e) {
LOG.info("Caught exception in negative Master connectivity test", e);
assertEquals("Found unexpected exception", RetriesExhaustedException.class,
e.getClass());
}
return null;
}
});
LOG.info("Executing request to HBase RegionServer which should fail");
user1.doAs(new PrivilegedExceptionAction<Void>() {
@Override public Void run() throws Exception {
try (Connection conn = ConnectionFactory.createConnection(clientConf);
Table t = conn.getTable(tableName)) {
t.get(new Get(Bytes.toBytes("r1")));
fail("Should not successfully authenticate with HBase");
} catch (Exception e) {
LOG.info("Caught exception in negative RegionServer connectivity test", e);
assertEquals("Found unexpected exception", RetriesExhaustedException.class,
e.getClass());
}
return null;
}
});
}
}
Also FYI validateRootCause method of master fails as here we get 'Connection reset by peer' as message in the RetriesExhaustedException. Maybe this is expected for branch-2.
There was a problem hiding this comment.
I think this could be another issue, to unify the implementation of this test across different branches.
NihalJain
approved these changes
Sep 24, 2023
|
Overall looks good, +1 |
Apache9
added a commit
that referenced
this pull request
Sep 24, 2023
…5433) Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 8d91cd2)
Apache9
added a commit
that referenced
this pull request
Sep 24, 2023
…5433) Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 8d91cd2)
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…pache#5433) Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 8d91cd2) (cherry picked from commit e8aa715) Change-Id: I6b808870868fd5c681d0007d5976a3ea729d8e69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.