Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking #5390

Merged
merged 2 commits into from
Mar 28, 2024
Merged

HBASE-27993. AbstractFSWAL causes ArithmeticException due to improper logRollSize value checking #5390

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98e3f3
check that logRollSize must be positive when calculating max log files
teamconfx Sep 11, 2023
366c5fc
include logRollSize value in the error message
teamconfx Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,8 @@ protected long getFileNumFromFileName(Path fileName) {
}

private int calculateMaxLogFiles(Configuration conf, long logRollSize) {
checkArgument(logRollSize > 0,
"The log roll size cannot be zero or negative when calculating max log files.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better include the value of logRollSize in the error message?

Pair<Long, MemoryType> globalMemstoreSize = MemorySizeUtil.getGlobalMemStoreSize(conf);
return (int) ((globalMemstoreSize.getFirst() * 2) / logRollSize);
}
Expand Down