HBASE-28008 Add support for netty tcnative #5363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
force-pushed
the
HBASE-28008
branch
from
74e9a42 to
e1c4821
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
commented
Aug 21, 2023
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java
Show resolved
Hide resolved
anmolnar
approved these changes
Aug 24, 2023
Comment on lines
+91
to
+94
| public static final String TLS_ENABLED_PROTOCOLS = CONFIG_PREFIX + "enabledProtocols"; | ||
| public static final String TLS_CIPHER_SUITES = CONFIG_PREFIX + "ciphersuites"; | ||
| public static final String TLS_CERT_RELOAD = CONFIG_PREFIX + "certReload"; | ||
| public static final String TLS_USE_OPENSSL = CONFIG_PREFIX + "useOpenSsl"; |
There was a problem hiding this comment.
Why do you make these public? For consistency?
There was a problem hiding this comment.
Yea, IMO we should keep most config constants public. Even for an IA.Private class, if a user wants to pull in the config constants they should be able to. They open themselves up to risk of compatibility issues since it's still an IA.Private class, but imo when it comes to config constants it is less risky to use a constant than it is to hardcode a string that may change. Ideally we could refactor our config constant approach across the board to make them easier to integrate, but barring that I've been making consistency changes like this whenever I see them.
Comment on lines
+142
to
+147
| /** | ||
| * Not all of our default ciphers are available in OpenSSL. Takes our default cipher lists and | ||
| * filters them to only those available in OpenSsl. Does GCM first, then CBC because GCM tends to | ||
| * be better and faster, and we don't need to worry about the java8 vs 9 performance issue if | ||
| * OpenSSL is handling it. | ||
| */ |
There was a problem hiding this comment.
Nice approach. In ZooKeeper we simply don't set default cipher suites just let OpenSSL to decide. User can still override them though.
There was a problem hiding this comment.
Yea I went with this approach because I'm really not an SSL expert and dont have any opinions about the cipher suites used here or what's in openssl as defaults. So I figured I could make a least-invasive change which uses what was defaulted here an just filters to those that work.
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/tls/X509Util.java
Show resolved
Hide resolved
Apache9
approved these changes
Aug 27, 2023
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
bbeaudreault
added a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Andor Molnar <[email protected]>
bbeaudreault
added a commit
that referenced
this pull request
Sep 12, 2023
Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Andor Molnar <[email protected]>
wchevreuil
pushed a commit
to wchevreuil/hbase
that referenced
this pull request
Nov 2, 2023
Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Andor Molnar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is trivial, and I'm not sure how to unit test it given it requires tcnative to be on the classpath and on a supported architecture. I tested this in my environment with and without tcnative on the classpath.