Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22881 Fix non-daemon threads in hbase server implementation #536

Merged
merged 1 commit into from
Aug 28, 2019
Merged

HBASE-22881 Fix non-daemon threads in hbase server implementation #536

merged 1 commit into from
Aug 28, 2019

Conversation

sunhelly
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 106 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0 mvndep 33 Maven dependency ordering for branch
+1 mvninstall 364 branch-2 passed
+1 compile 157 branch-2 passed
+1 checkstyle 206 branch-2 passed
+1 shadedjars 276 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 108 branch-2 passed
0 spotbugs 100 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 419 branch-2 passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 323 the patch passed
+1 compile 160 the patch passed
+1 javac 160 the patch passed
+1 checkstyle 27 The patch passed checkstyle in hbase-common
+1 checkstyle 40 The patch passed checkstyle in hbase-client
-1 checkstyle 97 hbase-server: The patch generated 2 new + 153 unchanged - 4 fixed = 155 total (was 157)
+1 checkstyle 40 hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 286 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1035 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 127 the patch passed
+1 findbugs 550 the patch passed
_ Other Tests _
+1 unit 180 hbase-common in the patch passed.
+1 unit 212 hbase-client in the patch passed.
+1 unit 13065 hbase-server in the patch passed.
+1 unit 329 hbase-thrift in the patch passed.
+1 asflicense 130 The patch does not generate ASF License warnings.
18779
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fcee61cff48f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revision branch-2 / fe689bf
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/testReport/
Max. process+thread count 4617 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 103 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 346 branch-2 passed
+1 compile 152 branch-2 passed
+1 checkstyle 198 branch-2 passed
+1 shadedjars 289 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 114 branch-2 passed
0 spotbugs 106 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 456 branch-2 passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 327 the patch passed
+1 compile 142 the patch passed
+1 javac 142 the patch passed
+1 checkstyle 28 The patch passed checkstyle in hbase-common
+1 checkstyle 39 The patch passed checkstyle in hbase-client
-1 checkstyle 90 hbase-server: The patch generated 2 new + 153 unchanged - 4 fixed = 155 total (was 157)
+1 checkstyle 42 hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 281 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1088 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 112 the patch passed
+1 findbugs 520 the patch passed
_ Other Tests _
+1 unit 179 hbase-common in the patch passed.
+1 unit 215 hbase-client in the patch passed.
-1 unit 16208 hbase-server in the patch failed.
+1 unit 328 hbase-thrift in the patch passed.
+1 asflicense 135 The patch does not generate ASF License warnings.
21886
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotTemporaryDirectory
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 01c0427b9533 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revision branch-2 / a386c6c
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/testReport/
Max. process+thread count 4073 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 44 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 312 branch-2 passed
+1 compile 139 branch-2 passed
+1 checkstyle 184 branch-2 passed
+1 shadedjars 251 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 114 branch-2 passed
0 spotbugs 90 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 373 branch-2 passed
_ Patch Compile Tests _
0 mvndep 18 Maven dependency ordering for patch
+1 mvninstall 291 the patch passed
+1 compile 139 the patch passed
+1 javac 139 the patch passed
+1 checkstyle 28 The patch passed checkstyle in hbase-common
+1 checkstyle 37 The patch passed checkstyle in hbase-client
+1 checkstyle 80 hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1 checkstyle 39 hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 250 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 904 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 112 the patch passed
+1 findbugs 413 the patch passed
_ Other Tests _
+1 unit 176 hbase-common in the patch passed.
+1 unit 206 hbase-client in the patch passed.
-1 unit 9320 hbase-server in the patch failed.
+1 unit 239 hbase-thrift in the patch passed.
+1 asflicense 101 The patch does not generate ASF License warnings.
14211
Reason Tests
Failed junit tests hadoop.hbase.client.TestBlockEvictionFromClient
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b9b542473dbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revision branch-2 / caba5cf
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/testReport/
Max. process+thread count 4459 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Let me rerun build to make sure unrelated test failure.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 129 Docker mode activated.
_ Prechecks _
+1 dupname 1 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0 mvndep 21 Maven dependency ordering for branch
+1 mvninstall 453 branch-2 passed
+1 compile 173 branch-2 passed
+1 checkstyle 210 branch-2 passed
+1 shadedjars 325 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 114 branch-2 passed
0 spotbugs 116 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 485 branch-2 passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 336 the patch passed
+1 compile 143 the patch passed
+1 javac 143 the patch passed
+1 checkstyle 27 The patch passed checkstyle in hbase-common
+1 checkstyle 37 The patch passed checkstyle in hbase-client
+1 checkstyle 92 hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1 checkstyle 43 hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 287 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1035 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 111 the patch passed
+1 findbugs 479 the patch passed
_ Other Tests _
+1 unit 185 hbase-common in the patch passed.
+1 unit 229 hbase-client in the patch passed.
-1 unit 14418 hbase-server in the patch failed.
+1 unit 282 hbase-thrift in the patch passed.
+1 asflicense 89 The patch does not generate ASF License warnings.
20188
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux ad1346483137 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revision branch-2 / a18be19
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/testReport/
Max. process+thread count 4351 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/4/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 42 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ branch-2 Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 311 branch-2 passed
+1 compile 138 branch-2 passed
+1 checkstyle 181 branch-2 passed
+1 shadedjars 249 branch has no errors when building our shaded downstream artifacts.
+1 javadoc 114 branch-2 passed
0 spotbugs 90 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 396 branch-2 passed
_ Patch Compile Tests _
0 mvndep 17 Maven dependency ordering for patch
+1 mvninstall 288 the patch passed
+1 compile 136 the patch passed
+1 javac 136 the patch passed
+1 checkstyle 26 The patch passed checkstyle in hbase-common
+1 checkstyle 36 The patch passed checkstyle in hbase-client
+1 checkstyle 79 hbase-server: The patch generated 0 new + 153 unchanged - 4 fixed = 153 total (was 157)
+1 checkstyle 39 hbase-thrift: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 250 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 914 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 javadoc 111 the patch passed
+1 findbugs 424 the patch passed
_ Other Tests _
+1 unit 175 hbase-common in the patch passed.
+1 unit 217 hbase-client in the patch passed.
+1 unit 8977 hbase-server in the patch passed.
+1 unit 225 hbase-thrift in the patch passed.
+1 asflicense 113 The patch does not generate ASF License warnings.
13900
Subsystem Report/Notes
Docker Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/artifact/out/Dockerfile
GITHUB PR #536
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 16359bc54346 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-536/out/precommit/personality/provided.sh
git revision branch-2 / 9b9f055
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/testReport/
Max. process+thread count 4966 (vs. ulimit of 10000)
modules C: hbase-common hbase-client hbase-server hbase-thrift U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-536/5/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@saintstack saintstack merged commit 84b4a61 into apache:branch-2 Aug 28, 2019
asfgit pushed a commit that referenced this pull request Aug 28, 2019
@sunhelly @saintstack
HBASE-22881 Fix non-daemon threads in hbase server implementation (#512…
7a90c1a 
…) (#536)

Signed-off-by: stack <[email protected]>
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@sunhelly
HBASE-22881 Fix non-daemon threads in hbase server implementation (ap…
b5f3118 
…ache#512) (apache#536)

Signed-off-by: stack <[email protected]>
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
@sunhelly
HBASE-22881 Fix non-daemon threads in hbase server implementation (ap…
7d4c818 
…ache#512) (apache#536)

Signed-off-by: stack <[email protected]>
(cherry picked from commit 7a90c1a)

Change-Id: I262ff840f6e7c072306813f6c39a4e1456a64d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunhelly @Apache-HBase @saintstack