Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "HBASE-27892 Report memstore on-heap and off-heap size as jmx metrics (#5308)" #5311

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Revert "HBASE-27892 Report memstore on-heap and off-heap size as jmx metrics (#5308)" #5311

merged 1 commit into from
Jun 27, 2023
+0 −10

Conversation

petersomogyi
Copy link
Contributor

This reverts commit 7c49300.

@petersomogyi petersomogyi requested a review from virajjasani June 27, 2023 14:32
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 49s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
-1 ❌ mvninstall 1m 10s root in branch-2.4 failed.
-1 ❌ compile 0m 14s hbase-hadoop2-compat in branch-2.4 failed.
-1 ❌ compile 0m 10s hbase-server in branch-2.4 failed.
-0 ⚠️ checkstyle 0m 4s The patch fails to run checkstyle in hbase-server
+1 💚 spotless 0m 54s branch has no errors when running spotless:check.
-1 ❌ spotbugs 0m 13s hbase-hadoop2-compat in branch-2.4 failed.
-1 ❌ spotbugs 0m 6s hbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 59s the patch passed
+1 💚 compile 3m 19s the patch passed
-0 ⚠️ javac 0m 19s hbase-hadoop2-compat generated 47 new + 0 unchanged - 4 fixed = 47 total (was 4)
-0 ⚠️ javac 2m 46s hbase-server generated 195 new + 0 unchanged - 0 fixed = 195 total (was 0)
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 19m 51s Patch does not cause any errors with Hadoop 2.10.2 or 3.1.4 3.2.4 3.3.5.
+1 💚 spotless 1m 7s patch has no errors when running spotless:check.
+1 💚 spotbugs 3m 17s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 25s The patch does not generate ASF License warnings.
39m 4s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5311
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux e6cf1c4b44ef 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 7c49300
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-compile-hbase-hadoop2-compat.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-compile-hbase-server.txt
checkstyle https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-hbase-server.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-hadoop2-compat.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-hadoop2-compat.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@petersomogyi petersomogyi merged commit c0df943 into apache:branch-2.4 Jun 27, 2023
@petersomogyi petersomogyi deleted the revert-HBASE-27892 branch June 27, 2023 15:45
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 42s Docker mode activated.
-0 ⚠️ yetus 0m 6s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
-1 ❌ mvninstall 0m 49s root in branch-2.4 failed.
-1 ❌ compile 0m 9s hbase-hadoop2-compat in branch-2.4 failed.
-1 ❌ compile 0m 9s hbase-server in branch-2.4 failed.
-1 ❌ shadedjars 1m 36s branch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 6s hbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 6s Maven dependency ordering for patch
+1 💚 mvninstall 1m 50s the patch passed
+1 💚 compile 0m 50s the patch passed
+1 💚 javac 0m 8s hbase-hadoop-compat in the patch passed.
+1 💚 javac 0m 10s hbase-hadoop2-compat generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚 javac 0m 32s hbase-server in the patch passed.
+1 💚 shadedjars 3m 55s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 20s hbase-server generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
_ Other Tests _
+1 💚 unit 0m 23s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 20s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 125m 19s hbase-server in the patch passed.
141m 8s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #5311
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7a1e9e1c8ab1 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 7c49300
Default Java Temurin-1.8.0_352-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-hadoop2-compat.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-compile-hbase-server.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk8-hadoop2-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/testReport/
Max. process+thread count 3634 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 51s Docker mode activated.
-0 ⚠️ yetus 0m 5s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ branch-2.4 Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
-1 ❌ mvninstall 1m 14s root in branch-2.4 failed.
-1 ❌ compile 0m 11s hbase-hadoop2-compat in branch-2.4 failed.
-1 ❌ compile 0m 10s hbase-server in branch-2.4 failed.
-1 ❌ shadedjars 2m 9s branch has 20 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 6s hbase-server in branch-2.4 failed.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 1m 16s the patch passed
+1 💚 javac 0m 13s hbase-hadoop-compat in the patch passed.
+1 💚 javac 0m 13s hbase-hadoop2-compat generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚 javac 0m 50s hbase-server in the patch passed.
+1 💚 shadedjars 5m 2s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 29s hbase-server generated 79 new + 0 unchanged - 0 fixed = 79 total (was 0)
_ Other Tests _
+1 💚 unit 0m 29s hbase-hadoop-compat in the patch passed.
+1 💚 unit 0m 27s hbase-hadoop2-compat in the patch passed.
+1 💚 unit 142m 47s hbase-server in the patch passed.
163m 28s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5311
Optional Tests javac javadoc unit shadedjars compile
uname Linux c436b3009e97 5.4.0-1101-aws #109~18.04.1-Ubuntu SMP Mon Apr 24 20:40:49 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision branch-2.4 / 7c49300
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-hadoop2-compat.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-server.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/testReport/
Max. process+thread count 3859 (vs. ulimit of 30000)
modules C: hbase-hadoop-compat hbase-hadoop2-compat hbase-server U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5311/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@petersomogyi
Revert "HBASE-27892 Report memstore on-heap and off-heap size as jmx …
4ac7877 
…metrics (apache#5308)" (apache#5311)

This reverts commit 7c49300.

(cherry picked from commit c0df943)
Change-Id: I6e6aafda6ef5781761cf0bb5a3461b3060f6b94b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petersomogyi @Apache-HBase @virajjasani