HBASE-27905 Directly schedule procedures that do not need to acquire … #5267
+123
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Which are the current procedures that don't need any lock? Can we add the override for needLock on those procedures here?
Does this change add the risk of procedures that don't need lock to starve those that need locks? I'm not sure this is indeed an issue, just wonder if that was already considered here.
| @@ -272,6 +272,10 @@ protected boolean waitInitialized(TEnvironment env) { | |||
| return false; | |||
| } | |||
|
|
|||
| public boolean needLock() { | |||
Comment on lines
377
to
383
| if (hasNoLockNeededProcedure(queue)) { | ||
| if (LOG.isTraceEnabled()) { | ||
| LOG.trace("DO NOT remove {} from run queue because There are still procedures in the " | ||
| + "queue that do not need to acquire locks", queue); | ||
| } | ||
| return; | ||
| } |
There was a problem hiding this comment.
Mind explain why we do this here? I see removeFromRunQueue is called from several places, some apparently expecting the call to effectively remove the queue.
|
Thank you for your attention. @wchevreuil The background of the matter is this, I try to introduce a new Procedure in HBASE-26768 —— |
|
I've commented on the design doc. PTAL. I think first we need to polish the design, before actually writing the code. And this is a sueful feature, better also start a discussion thread in the mailing list and also post the design there. Thanks. |
Apache9
reviewed
Jul 3, 2023
| @@ -219,6 +222,9 @@ private <T extends Comparable<T>> Procedure<?> doPoll(final FairQueue<T> fairq) | |||
| // procedures, then we give up and remove the queue from run queue. | |||
| for (int i = 0, n = rq.size(); i < n; i++) { | |||
| Procedure<?> proc = rq.poll(); | |||
| if (!proc.needLock()) { | |||
There was a problem hiding this comment.
Why not add this logic in the below isLockReady method?
| @@ -368,6 +374,13 @@ private static <T extends Comparable<T>> void addToRunQueue(FairQueue<T> fairq, | |||
|
|
|||
| private static <T extends Comparable<T>> void removeFromRunQueue(FairQueue<T> fairq, | |||
| Queue<T> queue, Supplier<String> reason) { | |||
| if (hasNoLockNeededProcedure(queue)) { | |||
There was a problem hiding this comment.
Ideally, if there are still no lock procedure in the queue, we should not arrive here?
|
Thanks Duo. After I implement the optimization items you proposed, I will send an email to the community to discuss it. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…locks