HBASE-27762 Include EventType and ProcedureV2 pid in logging via MDC #5145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change, on the region server, we get log messages like, |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ndimiduk
force-pushed
the
27762-eventtype-pid-mdc
branch
from
8534d42 to
e065f93
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Apache9
reviewed
Mar 29, 2023
| @@ -96,6 +97,10 @@ public EventHandler prepare() throws Exception { | |||
| public void run() { | |||
| Span span = TraceUtil.getGlobalTracer().spanBuilder(getClass().getSimpleName()) | |||
| .setParent(Context.current().with(parent)).startSpan(); | |||
| // assume that this is the top of an execution on a new or reused thread, that we're safe to | |||
| // blast any existing MDC state. | |||
| MDC.clear(); | |||
There was a problem hiding this comment.
We only call clear at the beginning? Is it possible to clear MDC at the end of a execution?
There was a problem hiding this comment.
Sure, seems no harm in that. You'd like to see it clear on both beginning and end?
There was a problem hiding this comment.
I prefer we do something like
MDC.put("blabla", "blabla");
try {
...
} finally {
MDC.clear();
}
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
ndimiduk
force-pushed
the
27762-eventtype-pid-mdc
branch
from
e065f93 to
ce60ae8
Compare
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Test failure is https://issues.apache.org/jira/browse/HBASE-27720 . |
Apache9
approved these changes
Apr 6, 2023
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 17, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 17, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 17, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 28, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 28, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 28, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
to ndimiduk/hbase
that referenced
this pull request
Apr 28, 2023
…pache#5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 1, 2023
…5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 1, 2023
…5145) Signed-off-by: Duo Zhang <[email protected]>
ndimiduk
added a commit
that referenced
this pull request
May 1, 2023
…5145) Signed-off-by: Duo Zhang <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…pache#5145) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 1d3d900) Change-Id: Id2271f761dc7e858068d42f46e55a40eda4c5e36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.