Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2.5 #5089

ndimiduk · 2023-03-06T10:08:19Z

No description provided.

…plica region encodedNames or region names - Added sanity check to make sure input region encoded name or region name is valid - Assignment improvements pertaining to read replica regions - make several MetaTableAccessor methods more precise in their handling of replica regions - hbck2 setRegionStateInMeta and HBCKServerCrashProcedure handle read replicas - separate AM helper methods -- loading RegionInfo from cache vs. refreshing cache from meta - AM helper method support loading RegionInfo from cache via either region name and encoded region name (both caches are maintained, and under lock) - consolidate, extend tests to cover read replica regions Co-authored-by: Huaxiang Sun <[email protected]> Co-authored-by: Nick Dimiduk <[email protected]> Signed-off-by: Peter Somogyi <[email protected]>

Apache-HBase · 2023-03-07T12:37:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	branch-2.5 passed
+1 💚	compile	3m 2s	branch-2.5 passed
+1 💚	checkstyle	0m 53s	branch-2.5 passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 5s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 14s	the patch passed
+1 💚	compile	3m 1s	the patch passed
+1 💚	javac	3m 1s	the patch passed
+1 💚	checkstyle	0m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 0s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 25s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		41m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5089
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux b098ff8bb1c7 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2cdcab2`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-07T15:28:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s	branch-2.5 passed
+1 💚	compile	0m 50s	branch-2.5 passed
+1 💚	shadedjars	4m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	0m 50s	the patch passed
+1 💚	javac	0m 50s	the patch passed
+1 💚	shadedjars	4m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 35s	hbase-client in the patch passed.
+1 💚	unit	187m 45s	hbase-server in the patch passed.
		212m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#5089
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cc03482bc914 5.4.0-1092-aws #100~18.04.2-Ubuntu SMP Tue Nov 29 08:39:52 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2cdcab2`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/testReport/
Max. process+thread count	2202 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2023-03-07T16:37:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 57s	branch-2.5 passed
+1 💚	compile	1m 32s	branch-2.5 passed
+1 💚	shadedjars	7m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	branch-2.5 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 34s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	7m 18s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	4m 0s	hbase-client in the patch passed.
+1 💚	unit	241m 21s	hbase-server in the patch passed.
		281m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5089
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4cade683dd74 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `2cdcab2`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/testReport/
Max. process+thread count	2321 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5089/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Mar 6, 2023

This comment was marked as outdated.

Sign in to view

ndimiduk merged commit 6e31c18 into apache:branch-2.5 Mar 8, 2023

ndimiduk deleted the 27250-masterrpcservices-setregionstateinmeta-support-replica-regions-branch-2.5 branch March 8, 2023 13:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2.5 #5089

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2.5 #5089

ndimiduk commented Mar 6, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 7, 2023

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2.5 #5089

Backport "HBASE-27250 MasterRpcService#setRegionStateInMeta does not support replica region encodedNames or region names" to branch-2.5 #5089

Conversation

ndimiduk commented Mar 6, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 7, 2023

Apache-HBase commented Mar 7, 2023