Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-27638 Get slow/large log response that matched the ‘CLIENT_IP' … #5087

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

mokai87
Copy link
Contributor

@mokai87 mokai87 commented Mar 6, 2023

…without client port

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@pankaj72981 pankaj72981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mokai87 for raising the PR. Changes looks fine, can you please update help message in the ruby script as well.

@pankaj72981
Copy link
Contributor

@virajjasani Can you please have a look on this.

@pankaj72981 pankaj72981 requested a review from virajjasani June 5, 2023 20:15
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the changes, good to go after @pankaj72981's comments are addressed

@mokai87
Copy link
Contributor Author

mokai87 commented Jun 10, 2023

Thanks @mokai87 for raising the PR. Changes looks fine, can you please update help message in the ruby script as well.

@pankaj72981 Thanks for the review. Help message updated.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@virajjasani
Copy link
Contributor

thanks @mokai87!

@pankaj72981 sir, could you please also take another look?

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for branch
+1 💚 mvninstall 2m 57s master passed
+1 💚 compile 3m 54s master passed
+1 💚 checkstyle 0m 59s master passed
+1 💚 spotbugs 2m 5s master passed
+1 💚 spotless 0m 46s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 51s the patch passed
+1 💚 compile 3m 58s the patch passed
+1 💚 javac 3m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 rubocop 0m 5s No new issues.
+1 💚 spotbugs 2m 18s the patch passed
+1 💚 hadoopcheck 10m 17s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 30s The patch does not generate ASF License warnings.
39m 48s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5087
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless rubocop
uname Linux 5a995072b958 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3c12f7b
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 44s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 1s master passed
+1 💚 compile 1m 36s master passed
+1 💚 javadoc 0m 57s master passed
+1 💚 shadedjars 5m 20s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 2m 55s the patch passed
+1 💚 compile 1m 36s the patch passed
+1 💚 javac 1m 36s the patch passed
+1 💚 javadoc 0m 57s the patch passed
+1 💚 shadedjars 5m 17s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 262m 14s hbase-server in the patch passed.
+1 💚 unit 20m 42s hbase-mapreduce in the patch passed.
+1 💚 unit 7m 7s hbase-shell in the patch passed.
318m 2s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5087
Optional Tests javac javadoc unit compile shadedjars
uname Linux eef2589995ae 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3c12f7b
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/testReport/
Max. process+thread count 5795 (vs. ulimit of 30000)
modules C: hbase-server hbase-mapreduce hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5087/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@mokai87 mokai87 requested a review from pankaj72981 November 13, 2024 08:45
@pankaj72981 pankaj72981 merged commit 7fdc248 into apache:master Nov 13, 2024
1 check passed
pankaj72981 pushed a commit that referenced this pull request Nov 13, 2024
…without client port (#5087)

Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Pankaj Kumar<[email protected]>
(cherry picked from commit 7fdc248)
mokai87 added a commit to mokai87/hbase that referenced this pull request Nov 14, 2024
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)

Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Pankaj Kumar<[email protected]>
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)

Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Pankaj Kumar<[email protected]>
(cherry picked from commit 004ebe5)
pankaj72981 pushed a commit that referenced this pull request Nov 14, 2024
…without client port (#5087) (#6471)

Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: Pankaj Kumar<[email protected]>
(cherry picked from commit 004ebe5)
gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants