Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27216 Revisit the ReplicationSyncUp tool #4947

Closed
wants to merge 11 commits into from
Closed

HBASE-27216 Revisit the ReplicationSyncUp tool #4947

wants to merge 11 commits into from

Conversation

2005hithlj
Copy link
Contributor

Apache9 and others added 11 commits December 3, 2022 21:46
@Apache9
HBASE-27212 Implement a new table based replication queue storage and…
2dffb1f 
… make the minimum replication system work (apache#4672)

Signed-off-by: Xin Sun <[email protected]>
@Apache9
HBASE-27213 Add support for claim queue operation (apache#4708)
3065774 
Signed-off-by: Xin Sun <[email protected]>
@Apache9
HBASE-27214 Implement the new replication hfile/log cleaner (apache#4722
002df54 
)

Signed-off-by: Xin Sun <[email protected]>
@Apache9
HBASE-27215 Add support for sync replication (apache#4762)
2845e7d 
Signed-off-by: Xiaolin Ha <[email protected]>
@Apache9
HBASE-27392 Add a new procedure type for implementing some global ope…
0fc588d 
…rations such as migration (apache#4803)

Signed-off-by: Xin Sun <[email protected]>
@2005hithlj @Apache9
HBASE-27405 Fix the replication hfile/log cleaner report that the rep…
07c435a 
…lication table does not exist (apache#4811)

Signed-off-by: Duo Zhang <[email protected]>
@Apache9
HBASE-27218 Support rolling upgrading (apache#4808)
a22e4ed 
Signed-off-by: Yu Li <[email protected]>
@2005hithlj @Apache9
HBASE-27217 Revisit the DumpReplicationQueues tool (apache#4810)
a78aac5 
Signed-off-by: Duo Zhang <[email protected]>
@Apache9
HBASE-27429 Add exponential retry backoff support for MigrateReplicat…
d218c77 
…ionQueueFromZkToTableProcedure

Signed-off-by: Liangjun He <[email protected]>
@Apache9
HBASE-27430 Should disable replication log cleaner when migrating rep…
da59154 
…lication queue data (apache#4901)

Signed-off-by: Liangjun He <[email protected]>
@2005hithlj
HBASE-27216 Revisit the ReplicationSyncUp tool
f544e7d
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 2m 24s HBASE-27109/table_based_rqs passed
+1 💚 compile 0m 34s HBASE-27109/table_based_rqs passed
+1 💚 shadedjars 4m 2s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 23s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 14s root in the patch failed.
+1 💚 compile 0m 37s the patch passed
+1 💚 javac 0m 37s the patch passed
-1 ❌ shadedjars 3m 6s patch has 11 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 21s the patch passed
_ Other Tests _
-1 ❌ unit 0m 36s hbase-server in the patch failed.
14m 58s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4947
Optional Tests javac javadoc unit shadedjars compile
uname Linux 8c59d6631241 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / da59154
Default Java Temurin-1.8.0_352-b08
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/testReport/
Max. process+thread count 52 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 2m 45s HBASE-27109/table_based_rqs passed
+1 💚 compile 2m 25s HBASE-27109/table_based_rqs passed
+1 💚 checkstyle 0m 36s HBASE-27109/table_based_rqs passed
+1 💚 spotless 0m 43s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 31s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 35s root in the patch failed.
-1 ❌ compile 1m 2s hbase-server in the patch failed.
-0 ⚠️ javac 1m 2s hbase-server in the patch failed.
+1 💚 checkstyle 0m 32s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ hadoopcheck 1m 42s The patch causes 11 errors with Hadoop v3.2.4.
-1 ❌ hadoopcheck 3m 31s The patch causes 11 errors with Hadoop v3.3.4.
+1 💚 spotless 0m 39s patch has no errors when running spotless:check.
-1 ❌ spotbugs 1m 36s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
18m 52s
Reason Tests
FindBugs module:hbase-server
Unwritten field:OfflineTableReplicationQueueStorage.java:[line 234]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4947
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 3cb546e70882 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / da59154
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/patch-javac-3.2.4.txt
hadoopcheck https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/patch-javac-3.3.4.txt
spotbugs https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/console
versions git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ HBASE-27109/table_based_rqs Compile Tests _
+1 💚 mvninstall 4m 16s HBASE-27109/table_based_rqs passed
+1 💚 compile 1m 8s HBASE-27109/table_based_rqs passed
+1 💚 shadedjars 4m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 31s HBASE-27109/table_based_rqs passed
_ Patch Compile Tests _
-1 ❌ mvninstall 2m 17s root in the patch failed.
+1 💚 compile 0m 49s the patch passed
+1 💚 javac 0m 49s the patch passed
-1 ❌ shadedjars 3m 36s patch has 11 errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 27s the patch passed
_ Other Tests _
-1 ❌ unit 0m 52s hbase-server in the patch failed.
21m 7s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4947
Optional Tests javac javadoc unit shadedjars compile
uname Linux 01ad055a25d1 5.4.0-1088-aws #96~18.04.1-Ubuntu SMP Mon Oct 17 02:57:48 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-27109/table_based_rqs / da59154
Default Java Eclipse Adoptium-11.0.17+8
mvninstall https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
shadedjars https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/testReport/
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4947/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Jan 8, 2023

Thanks @2005hithlj for putting this up.

Let's convert this PR to draft. I will try to help here next week.

@Apache9 Apache9 force-pushed the HBASE-27109/table_based_rqs branch from da59154 to e4e3363 Compare January 10, 2023 07:41
@Apache9 Apache9 force-pushed the HBASE-27109/table_based_rqs branch from e4e3363 to ff31d25 Compare January 18, 2023 10:25
@Apache9
Copy link
Contributor

Apache9 commented Jan 19, 2023

Close in favor of #4966

@Apache9 Apache9 closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2005hithlj @Apache-HBase @Apache9