HBASE-27531 AsyncRequestFutureImpl unnecessarily clears meta cache for full server #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bbeaudreault
force-pushed
the
HBASE-27531
branch
from
ff21a5b to
ee4eba4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Current spotless failure is due to https://issues.apache.org/jira/browse/HBASE-27474. The net-new code here is clean for spotless. |
bbeaudreault
force-pushed
the
HBASE-27531
branch
from
ee4eba4 to
51f193c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bbeaudreault
force-pushed
the
HBASE-27531
branch
from
51f193c to
c842086
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
reviewed
Dec 22, 2022
| @@ -989,7 +989,7 @@ private void invokeCallBack(byte[] regionName, byte[] row, CResult result) { | |||
| } | |||
|
|
|||
| private void cleanServerCache(ServerName server, Throwable regionException) { | |||
| if (ClientExceptionsUtil.isMetaClearingException(regionException)) { | |||
| if (tableName == null && ClientExceptionsUtil.isMetaClearingException(regionException)) { | |||
There was a problem hiding this comment.
In which case tableName could be null?
There was a problem hiding this comment.
It's only null for HTableMultiplexer
There was a problem hiding this comment.
This reverts the logic back to pre-21775: 5f25985#diff-7c58ffd83c150488599591ed5a3a068599646ebdbbbfdcd2233386e5472cca35L921
The tableName == null check here was standing for very long prior to that. I don't think it was correct to remove, since in the tableName != null (most usages) we'd fall into updateCachedLocations which clears the cache just for the individual regions.
There was a problem hiding this comment.
@Apache9 can you give another look?
There was a problem hiding this comment.
@saintstack Do you still remember something sir? Skimmed the patch, I'm not sure why removing the tableName == null check can fix the problem described in HBASE-21775, as Tommy Li said
from what I can see, tableName shouldn't be null unless you manually create a BufferedMutatorImpl instead of using ConnectionFactory.createConnection().getBufferedMutator(). I not sure if the bufferedmutator would work at all without a table name.
Apache9
approved these changes
Jan 10, 2023
bbeaudreault
added a commit
that referenced
this pull request
Jan 10, 2023
…r full server (#4930) Signed-off-by: Duo Zhang <[email protected]>
stoty
pushed a commit
to stoty/hbase
that referenced
this pull request
Nov 26, 2024
… clears meta cache for full server (apache#4930) (apache#158) * CDPD-73638: Backport HBASE-27531 AsyncRequestFutureImpl unnecessarily clears meta cache for full server (apache#4930) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 1c98931) Change-Id: If18b2add03e0509b7b778fcb14c2448353adf442 * CDPD-73638 - TestAsyncProcess.java fix Change-Id: I1d18f40b052ca2b62bd5428678cbd6a90a859977 --------- Co-authored-by: Bryan Beaudreault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts to the original behavior prior to https://issues.apache.org/jira/browse/HBASE-21775, which never cleared the full server cache for normal multigets. The null tableName scenario is only in the case of HTableMultiplexer, otherwise tableName is always available. It only makes sense to clear the full cache for requests where we can't determine the correct region to clear, like in HTableMultiplexer.
Skipping the full server clear here is good because:
cleanServerCacheis called has a subsequent call toupdateCachedLocationsfor the individual regions.The test provided in HBASE-21775 didn't actually test the problem. It just tested that the newly ungated call to cleanServerCache was called. I updated the tests here which help verify that the existing call to updateCachedLocations is enough to recover from any failure.
There are two ways errors are handled:
I added two test cases, one for each case.