HBASE-22833 MultiRowRangeFilter should provide a method for creating… #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a filter which is functionally equivalent to multiple prefix filters
titsuki
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
openinx
reviewed
Aug 15, 2019
| @@ -71,6 +72,22 @@ public MultiRowRangeFilter(List<RowRange> list) { | |||
| this.ranges = new RangeIteration(rangeList); | |||
| } | |||
|
|
|||
| /** | |||
| * @param rowKeyPrefixes the array of byte array | |||
There was a problem hiding this comment.
I think we need a careful javadoc here, say why we need the public method ... because exposing an MultiRowRangeFilter constructor with rowKeyPrefixes looks very strange if no doc here.
There was a problem hiding this comment.
OK, I added explanation for this constructor.
|
|
||
| private static List<RowRange> createRangeListFromRowKeyPrefixes(byte[][] rowKeyPrefixes) { | ||
| List<RowRange> list = new ArrayList<>(); | ||
| for (byte[] rowKeyPrefix: rowKeyPrefixes) { |
There was a problem hiding this comment.
Do we need some arguments check here ?
There was a problem hiding this comment.
OK, I added null check.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
openinx
approved these changes
Aug 16, 2019
|
The timeout snapshot related UT are irrelevant here. |
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Aug 16, 2019
…#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…apache#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…apache#493) * HBASE-22833: MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters * Delete superfluous comments * Add description for MultiRowRangeFilter constructor * Add null check for rowKeyPrefixes * Fix checkstyle Signed-off-by: huzheng <[email protected]> (cherry picked from commit bedab0d) Change-Id: I08b9252338009f3e2943cf15c109338a09634efa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a filter which is functionally equivalent to multiple prefix filters