HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) #4897

anmolnar · 2022-11-23T16:46:57Z

Backport of 047f4e2

…e changes in TLS connections (apache#4869) Signed-off-by: [email protected]

Apache-HBase · 2022-11-23T17:41:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 44s	branch-2 passed
+1 💚	compile	3m 27s	branch-2 passed
+1 💚	checkstyle	0m 57s	branch-2 passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 25s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	3m 25s	the patch passed
+1 💚	javac	3m 25s	the patch passed
-0 ⚠️	checkstyle	0m 11s	hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 29s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 49s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		36m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 1f197c14a814 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Eclipse Adoptium-11.0.17+8
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-common.txt
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bbeaudreault · 2022-11-23T20:48:52Z

@anmolnar looks like there's 1 checkstyle error -- just a line length issue. will need to fix that

Apache-HBase · 2022-11-23T20:55:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 24s	branch-2 passed
+1 💚	compile	1m 16s	branch-2 passed
+1 💚	shadedjars	3m 44s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	3m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 42s	hbase-common in the patch passed.
+1 💚	unit	2m 32s	hbase-client in the patch passed.
+1 💚	unit	203m 19s	hbase-server in the patch passed.
		230m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3f0f7a4b8457 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/testReport/
Max. process+thread count	2265 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-23T21:18:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s	branch-2 passed
+1 💚	compile	1m 26s	branch-2 passed
+1 💚	shadedjars	4m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 2s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	3m 55s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-common in the patch passed.
+1 💚	unit	2m 50s	hbase-client in the patch passed.
-1 ❌	unit	223m 21s	hbase-server in the patch failed.
		252m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8ba7a05a187e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Eclipse Adoptium-11.0.17+8
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/testReport/
Max. process+thread count	2632 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anmolnar · 2022-11-24T12:47:30Z

Thansk @bbeaudreault . I see a test timeout as well, let's see how it goes for the second time.

Apache-HBase · 2022-11-24T13:48:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	branch-2 passed
+1 💚	compile	3m 24s	branch-2 passed
+1 💚	checkstyle	0m 58s	branch-2 passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 27s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 25s	the patch passed
+1 💚	compile	3m 23s	the patch passed
+1 💚	javac	3m 23s	the patch passed
+1 💚	checkstyle	0m 54s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 23s	Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	2m 53s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		35m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux ec856f9557ec 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/console
versions	git=2.34.1 maven=3.8.6 spotbugs=4.7.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-24T17:24:15Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s	branch-2 passed
+1 💚	compile	1m 26s	branch-2 passed
+1 💚	shadedjars	4m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	4m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 3s	hbase-common in the patch passed.
+1 💚	unit	2m 43s	hbase-client in the patch passed.
+1 💚	unit	221m 53s	hbase-server in the patch passed.
		251m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 86d0d6b201f4 5.4.0-131-generic #147-Ubuntu SMP Fri Oct 14 17:07:22 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/testReport/
Max. process+thread count	2388 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-11-24T17:31:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 23s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 21s	branch-2 passed
+1 💚	compile	1m 43s	branch-2 passed
+1 💚	shadedjars	4m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 24s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	4m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 27s	hbase-common in the patch passed.
+1 💚	unit	3m 2s	hbase-client in the patch passed.
+1 💚	unit	224m 13s	hbase-server in the patch passed.
		258m 17s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4897
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e701f4fdba22 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `82cbf6b`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/testReport/
Max. process+thread count	2582 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4897/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

anmolnar · 2022-11-24T18:45:42Z

@bbeaudreault All green.

…e changes in TLS connections (branch-2) (apache#4897) Signed-off-by: Bryan Beaudreault <[email protected]>

* HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty handler (apache#4624) * HBASE-27185 Addendum fix TestShadeSaslAuthenticationProvider * HBASE-27271 BufferCallBeforeInitHandler should ignore the flush request (apache#4676) * HBASE-26666 Add native TLS encryption support to RPC server/client (apache#4666) * HBASE-27278 Improve TestTlsIPC to reuse existing IPC test code (apache#4682) * HBASE-27279 Make SslHandler work with SaslWrapHandler/SaslUnwrapHandler (apache#4705) * HBASE-27342 Use Hadoop Credentials API to retrieve passwords of TLS key/trust stores (apache#4751) * HBASE-27346 Autodetect key/truststore file type from file extension (apache#4757) * HBASE-27280 Add mutual authentication support to TLS (apache#4796) * HBASE-27673 Fix mTLS client hostname verification (apache#5066) * HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897) * HBASE-27779 Make X509Util config constants public * HBASE-27578 Upgrade hbase-thirdparty to 4.1.4 (apache#4985)

Backporting of HBASE-27347: FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) (apache#4897) Signed-off-by: Bryan Beaudreault <[email protected]> (cherry picked from commit e90a351) Change-Id: Ia0848cd0791b05edf30c174f28c893c7601df097

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststor…

b506c4f

…e changes in TLS connections (apache#4869) Signed-off-by: [email protected]

HBASE-27347. Checkstyle fix

5f7f5e6

bbeaudreault merged commit e90a351 into apache:branch-2 Nov 28, 2022

anmolnar deleted the HBASE-27347_2 branch November 28, 2022 14:19

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 2, 2023

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststor…

b8cb2c3

…e changes in TLS connections (branch-2) (apache#4897) Signed-off-by: Bryan Beaudreault <[email protected]>

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 2, 2023

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststor…

472c433

…e changes in TLS connections (branch-2) (apache#4897) Signed-off-by: Bryan Beaudreault <[email protected]>

bbeaudreault pushed a commit to HubSpot/hbase that referenced this pull request Apr 4, 2023

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststor…

ca80265

…e changes in TLS connections (branch-2) (apache#4897) Signed-off-by: Bryan Beaudreault <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) #4897

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) #4897

anmolnar commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

bbeaudreault commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

anmolnar commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

anmolnar commented Nov 24, 2022

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) #4897

HBASE-27347 Port FileWatcher from ZK to autodetect keystore/truststore changes in TLS connections (branch-2) #4897

Conversation

anmolnar commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

bbeaudreault commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

Apache-HBase commented Nov 23, 2022

anmolnar commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

Apache-HBase commented Nov 24, 2022

anmolnar commented Nov 24, 2022