-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27448 Add an admin method to get replication enabled state #4855
Conversation
@@ -271,6 +271,15 @@ private void setPeerState(String peerId, boolean enabled) throws ReplicationExce | |||
desc.getSyncReplicationState())); | |||
} | |||
|
|||
public boolean getPeerState(String peerId) throws ReplicationException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better add a method to get the ReplicationPeerDescription? Anyway, not a big problem since this class is IA.Private.
* @return <code>true</code> if replication peer is enabled | ||
* @throws IOException if a remote or network exception occurs | ||
*/ | ||
boolean isReplicationPeerEnabled(String peerId) throws IOException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better put this method together with other replication related method :)
HBaseClassTestRule.forClass(TestGetReplicationPeerState.class); | ||
|
||
@Test | ||
public void testGetReplicationPeerState() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this to another existing test classes?
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@Apache9 sir. Could you take a look? Thanks. |
https://issues.apache.org/jira/browse/HBASE-27448