HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept… #4829

vli02 · 2022-10-12T23:20:46Z

…ion.

Apache-HBase · 2022-10-12T23:44:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 48s	master passed
+1 💚	compile	0m 13s	master passed
+1 💚	shadedjars	4m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 13s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 12s	the patch passed
+1 💚	javac	0m 12s	the patch passed
+1 💚	shadedjars	4m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 40s	hbase-zookeeper in the patch passed.
		18m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux de1e22c2e160 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/testReport/
Max. process+thread count	212 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-12T23:44:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 11s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 21s	master passed
+1 💚	compile	0m 14s	master passed
+1 💚	shadedjars	4m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 14s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s	the patch passed
+1 💚	compile	0m 14s	the patch passed
+1 💚	javac	0m 14s	the patch passed
+1 💚	shadedjars	4m 28s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 42s	hbase-zookeeper in the patch passed.
		19m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux fcb5be87e929 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/testReport/
Max. process+thread count	229 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-12T23:46:54Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	checkstyle	0m 8s	master passed
+1 💚	spotless	0m 39s	branch has no errors when running spotless:check.
+1 💚	spotbugs	0m 20s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 11s	the patch passed
+1 💚	compile	0m 16s	the patch passed
+1 💚	javac	0m 16s	the patch passed
+1 💚	checkstyle	0m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 2s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	0m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 9s	The patch does not generate ASF License warnings.
		21m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 829b9171a2fb 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-zookeeper U: hbase-zookeeper
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

Left a couple minor comments, the fix looks reasonable

virajjasani · 2022-10-13T05:40:47Z

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java

    }
+    LOG.info("ZKWatcher close finished.");


I think this is redundant, can be removed.

virajjasani · 2022-10-13T05:41:03Z

hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKWatcher.java

@@ -735,13 +735,21 @@ public void interruptedExceptionNoThrow(InterruptedException ie, boolean throwLa
   */
  @Override
  public void close() {
+    LOG.info("ZKWatcher close started.");


This one also can be removed

virajjasani · 2022-10-13T05:45:49Z

@vli02 could you please add just one extra line on hbase-server/pom.xml just so that all hbase-server tests would be run.
Once we are good to merge, this minor change can be reverted.

Apache-HBase · 2022-10-13T16:45:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	checkstyle	0m 36s	master passed
+1 💚	spotless	0m 40s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 9s	the patch passed
+1 💚	compile	2m 33s	the patch passed
+1 💚	javac	2m 33s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	8m 5s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		30m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux 3a3250b4a32d 5.4.0-1085-aws #92~18.04.1-Ubuntu SMP Wed Aug 31 17:21:08 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-13T19:59:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 19s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 20s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	shadedjars	4m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 32s	hbase-zookeeper in the patch passed.
+1 💚	unit	204m 23s	hbase-server in the patch passed.
		224m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 80fd6c4bd212 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/testReport/
Max. process+thread count	2589 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-13T20:15:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 37s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	3m 47s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-zookeeper in the patch passed.
-1 ❌	unit	219m 40s	hbase-server in the patch failed.
		239m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0cd6791c4512 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Eclipse Adoptium-11.0.16.1+1
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/testReport/
Max. process+thread count	2458 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-14T07:00:37Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 7s	master passed
+1 💚	compile	2m 30s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 36s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 28s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	2m 27s	the patch passed
+1 💚	javac	2m 27s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 49s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 35s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		29m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux d946b12cd6db 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-14T10:13:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 9s	master passed
+1 💚	compile	0m 44s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s	the patch passed
+1 💚	compile	0m 45s	the patch passed
+1 💚	javac	0m 45s	the patch passed
+1 💚	shadedjars	4m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-zookeeper in the patch passed.
+1 💚	unit	203m 33s	hbase-server in the patch passed.
		222m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 468b58438b57 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/testReport/
Max. process+thread count	2655 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-14T10:22:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 34s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	3m 46s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 32s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	3m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 37s	hbase-zookeeper in the patch passed.
+1 💚	unit	211m 5s	hbase-server in the patch passed.
		230m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 28ad9195945e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/testReport/
Max. process+thread count	2793 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

virajjasani · 2022-10-14T19:44:28Z

@vli02 thanks for the changes! Now we can revert eb154ba on this PR, we are good to go.
Once reverted, will merge the PR and cherry-pick to later branches unless there are any objections.

Apache-HBase · 2022-10-14T20:36:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 38s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 38s	master passed
+1 💚	compile	3m 1s	master passed
+1 💚	checkstyle	0m 40s	master passed
+1 💚	spotless	0m 44s	branch has no errors when running spotless:check.
+1 💚	spotbugs	2m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 8s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 29s	the patch passed
+1 💚	compile	2m 36s	the patch passed
+1 💚	javac	2m 36s	the patch passed
+1 💚	checkstyle	0m 33s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 54s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 36s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 42s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		31m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux 0a4c7605eab5 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-14T23:51:18Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 2s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	4m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-zookeeper in the patch passed.
+1 💚	unit	204m 20s	hbase-server in the patch passed.
		225m 55s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 42cd8efc6cc1 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/testReport/
Max. process+thread count	2646 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-14T23:54:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	shadedjars	3m 43s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 33s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	3m 44s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-zookeeper in the patch passed.
+1 💚	unit	210m 21s	hbase-server in the patch passed.
		229m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 90671239e00e 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/testReport/
Max. process+thread count	2829 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…mes out.

Apache-HBase · 2022-10-15T05:55:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 36s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 31s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 2s	master passed
+1 💚	compile	2m 36s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	spotless	0m 37s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	2m 40s	the patch passed
+1 💚	javac	2m 40s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 0s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	7m 55s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 37s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 44s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		29m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile spotbugs hbaseanti checkstyle
uname	Linux b3773b8d2e49 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.7.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-15T09:07:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 5s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 59s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	3m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 33s	hbase-zookeeper in the patch passed.
+1 💚	unit	204m 33s	hbase-server in the patch passed.
		222m 20s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e60b438978ac 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Temurin-1.8.0_345-b01
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/testReport/
Max. process+thread count	2643 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-10-15T09:14:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 25s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	3m 45s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	3m 45s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 38s	hbase-zookeeper in the patch passed.
+1 💚	unit	210m 26s	hbase-server in the patch passed.
		229m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4829
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux bf2a1f34adb2 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `0d260f5`
Default Java	Eclipse Adoptium-11.0.16.1+1
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/testReport/
Max. process+thread count	2376 (vs. ulimit of 30000)
modules	C: hbase-zookeeper hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4829/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

#4829) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Co-authored-by: Victor Li <[email protected]>

apache#4829) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> Co-authored-by: Victor Li <[email protected]> (cherry picked from commit 39c596f) Change-Id: Iddff2292973d841df0ca5ec0bd01c0e658723d6c

HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept…

f4cac8b

…ion.

virajjasani reviewed Oct 13, 2022

View reviewed changes

Victor Li added 2 commits October 13, 2022 09:03

Remove unnecessary/redundant logs.

c6aa731

Dummy change for triggering tests in hbase-server.

eb154ba

virajjasani previously approved these changes Oct 14, 2022

View reviewed changes

Revert the dummy change.

258ee35

Reduce the wait to 15 seconds and add a force shutdown if the wait ti…

67394bd

…mes out.

apurtell approved these changes Oct 17, 2022

View reviewed changes

apurtell merged commit 77a21b9 into apache:master Oct 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept… #4829

HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept… #4829

vli02 commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

virajjasani left a comment

virajjasani Oct 13, 2022

virajjasani Oct 13, 2022

virajjasani commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

virajjasani left a comment

virajjasani commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 15, 2022

Apache-HBase commented Oct 15, 2022

Apache-HBase commented Oct 15, 2022

HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept… #4829

HBASE-27426 - Fix ZKWatcher shutdown seqence to avoid InterruptExcept… #4829

Conversation

vli02 commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

Apache-HBase commented Oct 12, 2022

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Oct 13, 2022

Choose a reason for hiding this comment

virajjasani Oct 13, 2022

Choose a reason for hiding this comment

virajjasani commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 13, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 14, 2022

Apache-HBase commented Oct 15, 2022

Apache-HBase commented Oct 15, 2022

Apache-HBase commented Oct 15, 2022