-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27422: Support replication for hbase:acl #4827
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*/ | ||
@InterfaceAudience.Private | ||
public class SystemTableWALEntryFilter implements WALEntryFilter { | ||
@Override | ||
public Entry filter(Entry entry) { | ||
if(entry.getKey().getTableName().equals( | ||
TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl"))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl"))) { | |
PermissionStorage.ACL_TABLE_NAME)) { |
final TableName ACL_TABLE_NAME = | ||
TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl"); | ||
WALKeyImpl key4 = | ||
new WALKeyImpl(new byte[0], ACL_TABLE_NAME, System.currentTimeMillis()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
final TableName ACL_TABLE_NAME = | |
TableName.valueOf(NamespaceDescriptor.SYSTEM_NAMESPACE_NAME_STR, "acl"); | |
WALKeyImpl key4 = | |
new WALKeyImpl(new byte[0], ACL_TABLE_NAME, System.currentTimeMillis()); | |
WALKeyImpl key4 = | |
new WALKeyImpl(new byte[0], PermissionStorage.ACL_TABLE_NAME, System.currentTimeMillis()); |
also need to fix the spotless by running |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎊 +1 overall
This message was automatically generated. |
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/SystemTableWALEntryFilter.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
the JDK 11 tests |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Any updates here? Which branches do you guys want this PR to go into? Thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@taklwu Would you please merge this? I think you guys have some discussions offline so you would have more context on which branches should this PR go in. Thanks. |
let me check the precommit and merge it, thanks duo |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Ankit Singhal <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 856fa14)
Signed-off-by: Ankit Singhal <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 856fa14)
Signed-off-by: Ankit Singhal <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry-picked from commit 856fa14)
Signed-off-by: Ankit Singhal <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry-picked from commit 856fa14) (cherry picked from commit 81671f2) Change-Id: I7a9478b203ab4bd1174aa70e8ee5004c2d3be4bf
Jira: https://issues.apache.org/jira/browse/HBASE-27422