HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… #4768

comnetwork · 2022-09-07T12:28:01Z

…ionsEnabled check

Apache-HBase · 2022-09-07T13:03:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 26s	master passed
+1 💚	compile	2m 15s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 8s	the patch passed
+1 💚	compile	2m 14s	the patch passed
+1 💚	javac	2m 14s	the patch passed
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 58s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 39s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		28m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 3838dc595340 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2cc840`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-07T16:02:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 44s	master passed
+1 💚	compile	0m 43s	master passed
-1 ❌	shadedjars	0m 8s	branch has 7 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	shadedjars	3m 59s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	192m 58s	hbase-server in the patch failed.
		206m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3b6a54a40045 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2cc840`
Default Java	AdoptOpenJDK-11.0.10+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/testReport/
Max. process+thread count	2821 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-07T16:38:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 33s	master passed
+1 💚	compile	0m 52s	master passed
+1 💚	shadedjars	5m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	compile	0m 44s	the patch passed
+1 💚	javac	0m 44s	the patch passed
+1 💚	shadedjars	4m 46s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	219m 8s	hbase-server in the patch passed.
		243m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0f8075606420 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d2cc840`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/testReport/
Max. process+thread count	2627 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-09-08T01:47:27Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java

@@ -229,8 +229,10 @@ private synchronized void requestSplit(final Region r, byte[] midKey) {
   */
  private synchronized void requestSplit(final Region r, byte[] midKey, User user) {
    if (midKey == null) {
-      LOG.debug("Region " + r.getRegionInfo().getRegionNameAsString()
-        + " not splittable because midkey=null");
+      if (LOG.isDebugEnabled()) {


Are these logging changes related?

no, it is not related, just modified by the way.

Apache9 · 2022-09-08T01:48:43Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java

@@ -312,14 +316,20 @@ public void switchCompaction(boolean onOrOff) {
    if (onOrOff) {
      // re-create executor pool if compactions are disabled.
      if (!isCompactionsEnabled()) {
-        LOG.info("Re-Initializing compactions because user switched on compactions");
+        if (LOG.isInfoEnabled()) {


I prefer we keep the old style.

Ok, I have reverted it.

If we want to align them, I prefer we open a new issue.

Apache9 · 2022-09-08T01:49:45Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java

@@ -336,6 +346,13 @@ private void requestCompactionInternal(HRegion region, String why, int priority,
  protected void requestCompactionInternal(HRegion region, HStore store, String why, int priority,
    boolean selectNow, CompactionLifeCycleTracker tracker,
    CompactionCompleteTracker completeTracker, User user) throws IOException {
+    if (!this.isCompactionsEnabled()) {


So this is the actual fix?

yes, it is the actual fix.

Apache-HBase · 2022-09-08T03:13:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 24s	master passed
+1 💚	compile	2m 16s	master passed
+1 💚	checkstyle	0m 32s	master passed
+1 💚	spotless	0m 41s	branch has no errors when running spotless:check.
+1 💚	spotbugs	1m 18s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 10s	the patch passed
+1 💚	compile	2m 18s	the patch passed
+1 💚	javac	2m 18s	the patch passed
+1 💚	checkstyle	0m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	7m 52s	Patch does not cause any errors with Hadoop 3.2.4 3.3.4.
+1 💚	spotless	0m 38s	patch has no errors when running spotless:check.
+1 💚	spotbugs	1m 23s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		28m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname	Linux 97e34b50b6f2 5.4.0-124-generic #140-Ubuntu SMP Thu Aug 4 02:23:37 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fa3bd7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java

Apache-HBase · 2022-09-08T07:42:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 7s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	shadedjars	4m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 27s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	shadedjars	4m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 32s	the patch passed
		_ Other Tests _
+1 💚	unit	273m 14s	hbase-server in the patch passed.
		297m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 214deb71d4a7 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fa3bd7f`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/testReport/
Max. process+thread count	2626 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-09-08T07:51:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 44s	master passed
+1 💚	compile	0m 42s	master passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 8s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	shadedjars	4m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	284m 12s	hbase-server in the patch failed.
		306m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4768
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78916d8cb77a 5.4.0-1081-aws #88~18.04.1-Ubuntu SMP Thu Jun 23 16:29:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fa3bd7f`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/testReport/
Max. process+thread count	2596 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4768/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ionsEnabled check (#4768) Co-authored-by: comnetwork <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit a26cbf1)

…ionsEnabled check (apache#4768) Co-authored-by: comnetwork <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit a26cbf1)

ndimiduk · 2022-09-08T12:59:37Z

Nice one 👍

…ionsEnabled check (apache#4768) Co-authored-by: comnetwork <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit a26cbf1) (cherry picked from commit b733485) Change-Id: Ie58f7748ff11422e1d76b405c1bf6c2989b8f649

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact…

6d7140a

…ionsEnabled check

Apache9 reviewed Sep 8, 2022

View reviewed changes

fix log

7b10b43

comnetwork requested a review from Apache9 September 8, 2022 02:46

Apache9 reviewed Sep 8, 2022

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java Show resolved Hide resolved

comnetwork requested a review from Apache9 September 8, 2022 05:58

Apache9 approved these changes Sep 8, 2022

View reviewed changes

Apache9 merged commit a26cbf1 into apache:master Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… #4768

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… #4768

comnetwork commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache9 Sep 8, 2022

comnetwork Sep 8, 2022

Apache9 Sep 8, 2022

comnetwork Sep 8, 2022 •

edited

Loading

Apache9 Sep 8, 2022

Apache9 Sep 8, 2022

comnetwork Sep 8, 2022

Apache-HBase commented Sep 8, 2022

Apache-HBase commented Sep 8, 2022

Apache-HBase commented Sep 8, 2022

ndimiduk commented Sep 8, 2022

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… #4768

HBASE-27362 CompactSplit.requestCompactionInternal may bypass compact… #4768

Conversation

comnetwork commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache-HBase commented Sep 7, 2022

Apache9 Sep 8, 2022

Choose a reason for hiding this comment

comnetwork Sep 8, 2022

Choose a reason for hiding this comment

Apache9 Sep 8, 2022

Choose a reason for hiding this comment

comnetwork Sep 8, 2022 • edited Loading

Choose a reason for hiding this comment

Apache9 Sep 8, 2022

Choose a reason for hiding this comment

Apache9 Sep 8, 2022

Choose a reason for hiding this comment

comnetwork Sep 8, 2022

Choose a reason for hiding this comment

Apache-HBase commented Sep 8, 2022

Apache-HBase commented Sep 8, 2022

Apache-HBase commented Sep 8, 2022

ndimiduk commented Sep 8, 2022

comnetwork Sep 8, 2022 •

edited

Loading