-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26649 Support meta replica LoadBalance mode for RegionLocator#g… #4464
Conversation
Hi @Apache9, please help to review the synchronous version of listAllRegions() change, thanks. |
💔 -1 overall
This message was automatically generated. |
9db9f24
to
1ad53f1
Compare
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Please run 'mvn spotless:apply' to fix the spotless errors? |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Will do and update accordingly, thanks! |
1ad53f1
to
7787ad2
Compare
💔 -1 overall
This message was automatically generated. |
…etAllRegionLocations() (apache#4442) Signed-off-by: Duo Zhang <[email protected]>
7787ad2
to
1ceb7e7
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Run the failed test case TestAsyncTableScanner#testReverseScanNoStopKey locally, it passed. Look a bit closer to the error,
Cannot map the tracestack to my git branch. It is something related with tracing, @ndimiduk, can you help o how to parse this assert? I cannot find assertTraceContinuity() in TestAsyncTableScanner class, thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
I tried to get a clean unittest run. This time, it failed at TestSplitRegionWhileRSCrash. The logs show the test case timed out. Did a manual run locally and it passed. @Apache9 Can you help to review? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the difference compard to the PR for master is that we also need to change the sync client?
+1
Thanks, yeah, the async part is same. The sync part is the new development. |
…etAllRegionLocations() (#4442)
Signed-off-by: Duo Zhang [email protected]