-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-27054 testRegionReplicasOnLargeCluster flake fix #4454
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
As I mentioned on the JIRA I can repro this pretty readily in the environment I have set up for making a pass over these unit tests. Let me apply this locally there and observe. Thanks @d-c-manning |
Not able to reproduce after 5 runs of all balancer tests, waiting until 10... |
No failures. |
Thanks @d-c-manning ! |
…egionReplicasOnLargeCluster is flaky (#4454) Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplicaLargeCluster.java
…egionReplicasOnLargeCluster is flaky (#4454) Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplicaLargeCluster.java
…egionReplicasOnLargeCluster is flaky (#4454) Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancerRegionReplicaLargeCluster.java
…egionReplicasOnLargeCluster is flaky (apache#4454) Signed-off-by: Andrew Purtell <[email protected]>
…er.testRegionReplicasOnLargeCluster is flaky (apache#4454)" This reverts commit 2d70ca1.
…egionReplicasOnLargeCluster is flaky (apache#4454) Signed-off-by: Andrew Purtell <[email protected]> Change-Id: I56fd82961c16a7361a48d5e0d487599811e440d3
HBASE-27054
Testing locally, I was able to see 100% pass rate with 15 second
maxRunningTime
after making these changes. So I changed to inherit fromStochasticBalancerTestBase
instead ofStochasticBalancerTestBase2
. The major difference inStochasticBalancerTestBase2
for the purposes of this test is a 180 secondsmaxRunningTime
for the balancer, which should now be wasteful for this test. We can use the default 30 seconds, which we will inherit by usingStochasticBalancerTestBase
.