HBASE-27037 Display the region server state on the Web UI #4432

tomscut · 2022-05-15T13:19:24Z

Display the region server state on the Web UI.

Apache-HBase · 2022-05-15T13:55:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	10m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 24s	master passed
+1 💚	spotless	0m 59s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 58s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		20m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	dupname asflicense javac spotless
uname	Linux 3f5fcad18338 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `369adcd`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-15T17:13:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 22s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 55s	master passed
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 40s	the patch passed
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	207m 47s	hbase-server in the patch passed.
		218m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux 0059cf42ace1 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `369adcd`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/testReport/
Max. process+thread count	2433 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-15T17:25:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	10m 38s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 22s	master passed
+1 💚	javadoc	0m 43s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s	the patch passed
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	209m 48s	hbase-server in the patch failed.
		229m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux 1225007de4ce 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `369adcd`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/testReport/
Max. process+thread count	2537 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-18T05:02:56Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 13s	master passed
-1 ❌	spotless	0m 21s	branch has 25 errors when running spotless:check, run spotless:apply to fix.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	spotless	0m 15s	patch has 25 errors when running spotless:check, run spotless:apply to fix.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		10m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	dupname asflicense javac spotless
uname	Linux 48cc0e6237c5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-general-check/output/branch-spotless.txt
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count	66 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-18T08:30:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 43s	master passed
+1 💚	javadoc	0m 27s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 41s	the patch passed
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	208m 48s	hbase-server in the patch failed.
		218m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux e746d75b520d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/testReport/
Max. process+thread count	2436 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-18T08:30:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 42s	master passed
+1 💚	javadoc	0m 33s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 13s	the patch passed
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
-1 ❌	unit	207m 25s	hbase-server in the patch failed.
		218m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux 11334b90af2c 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `b787648`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/testReport/
Max. process+thread count	2583 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

pankaj72981

LGTM

tomscut · 2022-05-21T01:21:28Z

Thanks @pankaj72981 for your review.

tomscut · 2022-05-23T01:21:04Z

Hi @Apache9 @virajjasani , could you please also take a look. Thanks.

Apache9 · 2022-05-23T01:21:45Z

hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon

    String masterVersion = VersionInfo.getVersion();
+    List<ServerName> decommissionedServers = master.listDecommissionedRegionServers();


Better construct a Set here? The contains method run on List is O(n), although usually the number of decommissioned server will be small, but it is still no harm to use a Set here.

Thanks @Apache9 for your comment. I will update it later.

Apache-HBase · 2022-05-23T12:21:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 55s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 6s	master passed
+1 💚	spotless	0m 55s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 53s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		11m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	dupname asflicense javac spotless
uname	Linux ae068ad82b12 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-23T15:47:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 8s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 8s	master passed
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 2s	the patch passed
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	205m 27s	hbase-server in the patch passed.
		216m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux 7b401fe74441 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/testReport/
Max. process+thread count	2532 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-05-23T15:47:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 53s	master passed
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 38s	the patch passed
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	206m 33s	hbase-server in the patch passed.
		216m 52s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4432
Optional Tests	javac javadoc unit
uname	Linux b3a08bf55922 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1be2c83`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/testReport/
Max. process+thread count	2481 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4432/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tomscut · 2022-05-27T02:25:27Z

Hi @Apache9 , I updated the code, could you please have a look. Thanks a lot.

tomscut · 2022-05-30T01:46:38Z

Hi @virajjasani , could you please review this. Thanks.

Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit db99208)

Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

…ache#4432)" This reverts commit 5f87bc8.

HBASE-27037 Display the region server state on the Web UI

09b3b48

add blank space

2f09fb7

pankaj72981 approved these changes May 20, 2022

View reviewed changes

Apache9 reviewed May 23, 2022

View reviewed changes

change list to set to reduce complexity

12b2daa

tomscut requested a review from Apache9 May 25, 2022 10:42

Apache9 approved these changes Jun 2, 2022

View reviewed changes

Apache9 merged commit db99208 into apache:master Jun 2, 2022

Apache9 pushed a commit that referenced this pull request Jun 2, 2022

HBASE-27037 Display the region server state on the Web UI (#4432)

b21930f

Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit db99208)

wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

HBASE-27037 Display the region server state on the Web UI (apache#4432)

5f87bc8

Signed-off-by: Pankaj Kumar <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022

Revert "HBASE-27037 Display the region server state on the Web UI (ap…

0a0b2c3

…ache#4432)" This reverts commit 5f87bc8.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-27037 Display the region server state on the Web UI #4432

HBASE-27037 Display the region server state on the Web UI #4432

tomscut commented May 15, 2022 •

edited

Loading

Apache-HBase commented May 15, 2022

Apache-HBase commented May 15, 2022

Apache-HBase commented May 15, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

pankaj72981 left a comment

tomscut commented May 21, 2022

tomscut commented May 23, 2022

Apache9 May 23, 2022

tomscut May 23, 2022

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

tomscut commented May 27, 2022

tomscut commented May 30, 2022

		String masterVersion = VersionInfo.getVersion();
		List<ServerName> decommissionedServers = master.listDecommissionedRegionServers();

HBASE-27037 Display the region server state on the Web UI #4432

HBASE-27037 Display the region server state on the Web UI #4432

Conversation

tomscut commented May 15, 2022 • edited Loading

Apache-HBase commented May 15, 2022

Apache-HBase commented May 15, 2022

Apache-HBase commented May 15, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

Apache-HBase commented May 18, 2022

pankaj72981 left a comment

Choose a reason for hiding this comment

tomscut commented May 21, 2022

tomscut commented May 23, 2022

Apache9 May 23, 2022

Choose a reason for hiding this comment

tomscut May 23, 2022

Choose a reason for hiding this comment

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

Apache-HBase commented May 23, 2022

tomscut commented May 27, 2022

tomscut commented May 30, 2022

tomscut commented May 15, 2022 •

edited

Loading