HBASE-27030 Fix undefined local variable error in draining_servers.rb #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBASE-21812 replaced a for-loop with an each block.
Each block introduces a new scope, so a local variable defined inside it
cannot be accessed afterwards.
NameError: undefined local variable or method `admin' for main:Object
getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81
addServers at /opt/khp/hbase/bin/draining_servers.rb:88
<main> at /opt/khp/hbase/bin/draining_servers.rb:146
This commit defines the admin local variable in the current scope beforehand,
so that we can still access it after the block.
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
May 22, 2022
Apache9
pushed a commit
that referenced
this pull request
May 22, 2022
…#4427) HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. NameError: undefined local variable or method `admin' for main:Object getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81 addServers at /opt/khp/hbase/bin/draining_servers.rb:88 <main> at /opt/khp/hbase/bin/draining_servers.rb:146 This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block. Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2b573ae)
Apache9
pushed a commit
that referenced
this pull request
May 22, 2022
…#4427) HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. NameError: undefined local variable or method `admin' for main:Object getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81 addServers at /opt/khp/hbase/bin/draining_servers.rb:88 <main> at /opt/khp/hbase/bin/draining_servers.rb:146 This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block. Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2b573ae)
Apache9
pushed a commit
that referenced
this pull request
May 22, 2022
…#4427) HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. NameError: undefined local variable or method `admin' for main:Object getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81 addServers at /opt/khp/hbase/bin/draining_servers.rb:88 <main> at /opt/khp/hbase/bin/draining_servers.rb:146 This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block. Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2b573ae)
wenwj0
pushed a commit
to wenwj0/hbase
that referenced
this pull request
Jun 14, 2022
…apache#4427) HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. NameError: undefined local variable or method `admin' for main:Object getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81 addServers at /opt/khp/hbase/bin/draining_servers.rb:88 <main> at /opt/khp/hbase/bin/draining_servers.rb:146 This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block. Signed-off-by: Duo Zhang <[email protected]>
wenwj0
added a commit
to wenwj0/hbase
that referenced
this pull request
Jun 14, 2022
…rvers.rb (apache#4427)" This reverts commit 10634cc.
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
…apache#4427) HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards. NameError: undefined local variable or method `admin' for main:Object getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81 addServers at /opt/khp/hbase/bin/draining_servers.rb:88 <main> at /opt/khp/hbase/bin/draining_servers.rb:146 This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block. Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 2b573ae) Change-Id: Id7026f6f46e2149d458d1b69db82143fea5ba9aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards.
This commit defines the admin local variable in the current scope beforehand, so that we can still access it after the block.