Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory #4425

Merged
merged 1 commit into from
May 22, 2022
Merged

HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated SslContextFactory #4425

merged 1 commit into from
May 22, 2022

Conversation

bitterfox
Copy link
Contributor

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 21s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 37s master passed
+1 💚 compile 0m 58s master passed
+1 💚 shadedjars 3m 44s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 2m 35s the patch passed
+1 💚 compile 0m 58s the patch passed
+1 💚 javac 0m 58s the patch passed
+1 💚 shadedjars 3m 39s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 0s the patch passed
_ Other Tests _
+1 💚 unit 0m 43s hbase-http in the patch passed.
+1 💚 unit 6m 49s hbase-thrift in the patch passed.
+1 💚 unit 3m 1s hbase-rest in the patch passed.
29m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4425
Optional Tests javac javadoc unit shadedjars compile
uname Linux 28acfb0af08a 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a712f9f
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/testReport/
Max. process+thread count 1393 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 3m 13s master passed
+1 💚 compile 0m 44s master passed
+1 💚 shadedjars 3m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 2m 5s the patch passed
+1 💚 compile 0m 43s the patch passed
+1 💚 javac 0m 43s the patch passed
+1 💚 shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 39s the patch passed
_ Other Tests _
+1 💚 unit 0m 34s hbase-http in the patch passed.
+1 💚 unit 6m 27s hbase-thrift in the patch passed.
+1 💚 unit 3m 52s hbase-rest in the patch passed.
30m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4425
Optional Tests javac javadoc unit shadedjars compile
uname Linux c8f5f6e9f4e1 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a712f9f
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/testReport/
Max. process+thread count 1520 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 2m 18s master passed
+1 💚 compile 1m 15s master passed
+1 💚 checkstyle 0m 43s master passed
+1 💚 spotless 0m 40s branch has no errors when running spotless:check.
+1 💚 spotbugs 1m 28s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 3s the patch passed
+1 💚 compile 1m 14s the patch passed
+1 💚 javac 1m 14s the patch passed
+1 💚 checkstyle 0m 37s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 0s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotless 0m 37s patch has no errors when running spotless:check.
+1 💚 spotbugs 1m 46s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
31m 26s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4425
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile
uname Linux 4ebf08c5c216 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a712f9f
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 69 (vs. ulimit of 30000)
modules C: hbase-http hbase-thrift hbase-rest U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4425/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented May 13, 2022

Which branches should this change be applied? Branch-2.4+ or branch-2.5+?

@bitterfox
Copy link
Contributor Author

bitterfox commented May 13, 2022 •
edited
Loading

Thank you for checking this.

We need this change in both branches.

JFYI, the deprecation was released in jetty 9.4.16 and the breaking change that throws the exception is released in jetty 9.4.23, so branches using jetty 9.4.23+ are affected
jetty/jetty.project@6fb243f
jetty/jetty.project@f4d387e
jetty/jetty.project@53073ca

@Apache9 Apache9 merged commit 1be2c83 into apache:master May 22, 2022
Apache9 pushed a commit that referenced this pull request May 22, 2022
@bitterfox @Apache9
HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated …
075f6e6 
…SslContextFactory (#4425)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 1be2c83)
Apache9 pushed a commit that referenced this pull request May 22, 2022
@bitterfox @Apache9
HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated …
b83e03a 
…SslContextFactory (#4425)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 1be2c83)
Apache9 pushed a commit that referenced this pull request May 22, 2022
@bitterfox @Apache9
HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated …
a6b1c7e 
…SslContextFactory (#4425)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 1be2c83)
wenwj0 pushed a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
@bitterfox @wenwj0
HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated …
67aee05 
…SslContextFactory (apache#4425)

Signed-off-by: Duo Zhang <[email protected]>
wenwj0 added a commit to wenwj0/hbase that referenced this pull request Jun 14, 2022
@wenwj0
Revert "HBASE-27027 Use jetty SslContextFactory.Server instead of dep…
5fb5222 
…recated SslContextFactory (apache#4425)"

This reverts commit 67aee05.
vinayakphegde pushed a commit to vinayakphegde/hbase that referenced this pull request Apr 4, 2024
@bitterfox
HBASE-27027 Use jetty SslContextFactory.Server instead of deprecated …
36e3413 
…SslContextFactory (apache#4425)

Signed-off-by: Duo Zhang <[email protected]>
(cherry picked from commit 1be2c83)

this has been done by CDPD-11097 internally

Change-Id: Ia77c623814287fdefd8ce2aa721dc0e2e732f71f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apache9 Apache9 Apache9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bitterfox @Apache-HBase @Apache9