-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26342 Support custom paths of independent configuration and pool for hfile cleaner #4403
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@@ -384,6 +387,9 @@ public class HMaster extends HBaseServerBase<MasterRpcServices> implements Maste | |||
private DirScanPool logCleanerPool; | |||
private LogCleaner logCleaner; | |||
private HFileCleaner hfileCleaner; | |||
private HFileCleaner[] customHFileCleaners; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just do an array or List of all HFileCleaner
s ? Is there a reason to manage hfileCleaner
and customHFileCleaners
separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collected the hfileCleaner and customHFileCleaners to a linked list, and let the default hfileCleaner be the first element. Thanks.
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
Outdated
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
private HFileCleaner hfileCleaner; | ||
// HFile cleaners for the custom hfile archive paths and the default archive path | ||
// The archive path cleaner is the first element | ||
private LinkedList<HFileCleaner> hfileCleaners = new LinkedList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The choice of LinkedList will trigger some static analysis tools to warn it is almost always a poor choice. In my opinion the use of LinkedList here makes sense but ArrayList would avoid that issue. Just a suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good suggestion!
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterChoreScheduled.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
…l for hfile cleaner
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…l for hfile cleaner (apache#4403) Signed-off-by: Andrew Purtell <[email protected]>
…l for hfile cleaner (#4403) (#4461) Signed-off-by: Andrew Purtell <[email protected]>
…l for hfile cleaner (#4403) (#4461) Signed-off-by: Andrew Purtell <[email protected]>
…l for hfile cleaner (apache#4403) Signed-off-by: Andrew Purtell <[email protected]>
… and pool for hfile cleaner (apache#4403)" This reverts commit 87c32f2.
No description provided.