HBASE-22776 Rename config names in user scan snapshot feature #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
openinx
reviewed
Aug 6, 2019
| @@ -511,9 +556,16 @@ boolean isNotFamilyOrQualifierPermission(TablePermission tablePermission) { | |||
| return !tablePermission.hasFamily() && !tablePermission.hasQualifier(); | |||
| } | |||
|
|
|||
| boolean isTableUserScanSnapshotEnabled(TableDescriptor tableDescriptor) { | |||
| public static boolean isAclSyncToHdfsEnabled(Configuration conf) { | |||
| String masterCoprocessors = conf.get(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY); | |||
There was a problem hiding this comment.
Use conf.getStrings to parse the masterCoprocessors ? and then use the HashSet to check the existence of SnapshotScannerHDFSAclController & AccessController ... that would be better...
| @@ -213,6 +213,7 @@ public void postCompletedSnapshotAction(ObserverContext<MasterCoprocessorEnviron | |||
| public void postCompletedTruncateTableAction(ObserverContext<MasterCoprocessorEnvironment> c, | |||
| TableName tableName) throws IOException { | |||
| if (needHandleTableHdfsAcl(tableName, "truncateTable " + tableName)) { | |||
| hdfsAclHelper.createTableDirectories(tableName); | |||
There was a problem hiding this comment.
Why create the table directories here ? I guess the TruncateTableProcedure will create the dir ?
There was a problem hiding this comment.
The tmp table dir is deleted after truncate table, so recreate this directory.
There was a problem hiding this comment.
So please add the comment to say : it's mainly used for creating tmp table dir here because ...
| public static final String USER_SCAN_SNAPSHOT_ENABLE = "hbase.user.scan.snapshot.enable"; | ||
| public static final String USER_SCAN_SNAPSHOT_THREAD_NUMBER = | ||
| "hbase.user.scan.snapshot.thread.number"; | ||
| public static final String ACL_SYNC_TO_HDFS_ENABLE = "hbase.acl.sync.to.hdfs.enable"; |
There was a problem hiding this comment.
better to name it as 'hbase.table.acl.sync.to.hdfs.enable' ?
There was a problem hiding this comment.
The steps to config this feature is as followings:
- Check HDFS configuration
- Add master coprocessor:
hbase.coprocessor.master.classes =
“org.apache.hadoop.hbase.security.access.AccessController
,org.apache.hadoop.hbase.security.access.SnapshotScannerHDFSAclController” - Enable this feature:
hbase.acl.sync.to.hdfs.enable=true - Modify table scheme to enable this feature:
alter 't1', CONFIGURATION => {'hbase.acl.sync.to.hdfs.enable' => 'true'}
So this config has two usages in both step 3 and 4.
If step3 is set, the acl will aync to HDFS if grant namespace or global.
Maybe 'hbase.table.acl.sync.to.hdfs.enable' is confused because global and namespace acls are also synced?
.../src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
Show resolved
Hide resolved
.../src/main/java/org/apache/hadoop/hbase/security/access/SnapshotScannerHDFSAclController.java
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
mymeiyi
force-pushed
the
hdfs-acl-rename
branch
from
b5d7560 to
02c82a2
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
openinx
approved these changes
Aug 7, 2019
| @@ -213,6 +213,7 @@ public void postCompletedSnapshotAction(ObserverContext<MasterCoprocessorEnviron | |||
| public void postCompletedTruncateTableAction(ObserverContext<MasterCoprocessorEnvironment> c, | |||
| TableName tableName) throws IOException { | |||
| if (needHandleTableHdfsAcl(tableName, "truncateTable " + tableName)) { | |||
| hdfsAclHelper.createTableDirectories(tableName); | |||
There was a problem hiding this comment.
So please add the comment to say : it's mainly used for creating tmp table dir here because ...
| public static final String USER_SCAN_SNAPSHOT_ENABLE = "hbase.user.scan.snapshot.enable"; | ||
| public static final String USER_SCAN_SNAPSHOT_THREAD_NUMBER = | ||
| "hbase.user.scan.snapshot.thread.number"; | ||
| public static final String ACL_SYNC_TO_HDFS_ENABLE = "hbase.acl.sync.to.hdfs.enable"; |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
mymeiyi
force-pushed
the
hdfs-acl-rename
branch
from
02c82a2 to
45fb768
Compare
mymeiyi
added a commit
that referenced
this pull request
Aug 8, 2019
|
💔 -1 overall
This message was automatically generated. |
chenxu14
pushed a commit
to chenxu14/hbase
that referenced
this pull request
Aug 12, 2019
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.