-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26982 Add index and bloom filter statistics of LruBlockCache on… #4376
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and this looks like it is still mergable
<%if lru %> | ||
<tr> | ||
<td>Size of Index Blocks</td> | ||
<td><% String.format("%,d", ((LruBlockCache)bc).getCurrentIndexSize()) %></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only improvement that needs be done here is these should also be formatted with TraditionalBinaryPrefix.long2String().
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@liangxs ,would you please fix the spotless error? |
Since it is approved, let me fix the spotless error and merge. |
Oh, I do not have access to your git repo. @liangxs, can you fix spotless error? Otherwise, it will be moved out of 2.5.0 and goes to 2.5.1, thanks. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice patch. Intend to merge later....
#4376) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: stack <[email protected]>
#4376) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: stack <[email protected]>
… rs web UI
HBASE JIRA HBASE-26982