-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25058 Export necessary modules when running under JDK11 #4337
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@ndimiduk Most illegal-access warnings have been purged. The remaining ones are only for tests so I think it is gnerally OK. Mind taking a look at the PR? I think our JDK11 support is good enough now :) |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No concerns from me, this looks good.
Sorry for the delayed review here @Apache9 , I'm back from some travel after the last couple weeks.
pom.xml
Outdated
--add-opens java.base/java.nio=ALL-UNNAMED | ||
--add-opens java.base/sun.nio.ch=ALL-UNNAMED | ||
--add-opens java.base/java.lang=ALL-UNNAMED | ||
--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one add-opens
line uses an =
to specify its argument, the rest don't. Mine making them all uniform? Same thing in bin/hbase
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, copy-paste error. Thanks for pointing this out.
Let me change it.
🎊 +1 overall
This message was automatically generated. |
Singed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82e47cd)
Singed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82e47cd)
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…#4337) Singed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82e47cd)
…#4337) Singed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit 82e47cd)
No description provided.