-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26943 HMaster page style display confusion #4336
Conversation
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @2005hithlj . I have two questions about the current PR:
- The content of the changed file (i.e.
bootstrap.min.css
) seems to be a one-liner (lack of normal line breakers). It's really hard to tell the real change according to the commit history, so I would suggest to split this PR into two commits: one for formatting and the other containing the real, easy-to-tell change to fix the margin-top issue. - The version of
normalize.css
inbootstrap.min.css
is3.0.3
, which is released on March 15th, 2015 and the latest version is already8.0.1
. Have you ever tried to use the latest version and see whether the problem could be resolved?
And to be explicit, I think the first point is better to resolve, while the second is nice to have.
Please feel free to let me know your thoughts.
💔 -1 overall
This message was automatically generated. |
Yes, upgrade normalize.css version needs a lot of compatibility tests. |
I have formatted bootstrap.min.css, @carp84 please review it, thanks. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The work is completed through #4341 |
https://issues.apache.org/jira/browse/HBASE-26943