HBASE-26842 fix TestSnapshotProcedure for branch-2 #4225

frostruan · 2022-03-15T12:05:54Z

No description provided.

Apache9

Let's wait for the pre commit result.

And we should also file an issue to forward port the test change to master branch.

frostruan · 2022-03-15T12:14:49Z

Ok. I'll start this work as soon as possible. Thanks for your great advise Duo. @Apache9

Apache-HBase · 2022-03-15T12:18:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --hadoop-profile --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
-1 ❌	mvninstall	0m 8s	root in branch-2 failed.
-1 ❌	compile	0m 18s	hbase-client in branch-2 failed.
-1 ❌	compile	0m 17s	hbase-server in branch-2 failed.
-0 ⚠️	javadoc	0m 5s	hbase-client in branch-2 failed.
-0 ⚠️	javadoc	0m 6s	hbase-server in branch-2 failed.
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 3s	Maven dependency ordering for patch
-1 ❌	mvninstall	0m 5s	hbase-client in the patch failed.
-1 ❌	mvninstall	0m 6s	hbase-server in the patch failed.
-1 ❌	compile	0m 5s	hbase-client in the patch failed.
-1 ❌	compile	0m 5s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 5s	hbase-client in the patch failed.
-0 ⚠️	javac	0m 5s	hbase-server in the patch failed.
-0 ⚠️	javadoc	0m 5s	hbase-client in the patch failed.
-0 ⚠️	javadoc	0m 5s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 5s	hbase-client in the patch failed.
-1 ❌	unit	0m 6s	hbase-server in the patch failed.
		3m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit compile
uname	Linux fe50c8d8d068 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e6879b8`
Default Java	AdoptOpenJDK-11.0.10+9
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/branch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-client.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/branch-compile-hbase-server.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-hbase-client.txt
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-hbase-server.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
javadoc	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-client.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/testReport/
Max. process+thread count	40 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T12:46:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	7m 38s	branch-2 passed
+1 💚	compile	2m 14s	branch-2 passed
+1 💚	checkstyle	1m 58s	branch-2 passed
+1 💚	spotbugs	4m 58s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 4s	the patch passed
+1 💚	compile	2m 5s	the patch passed
+1 💚	javac	2m 5s	the patch passed
-0 ⚠️	checkstyle	1m 11s	hbase-server: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotbugs	5m 4s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		32m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux c7ac781c57e9 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e6879b8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	57 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-15T15:12:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 3s	branch-2 passed
+1 💚	compile	1m 24s	branch-2 passed
+1 💚	javadoc	0m 54s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 28s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	javadoc	0m 54s	the patch passed
		_ Other Tests _
-1 ❌	unit	2m 26s	hbase-client in the patch failed.
-1 ❌	unit	161m 33s	hbase-server in the patch failed.
		178m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit compile
uname	Linux f36185558175 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `e6879b8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-client.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/testReport/
Max. process+thread count	1884 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

frostruan · 2022-03-15T18:42:32Z

There are five tests failing.

The two tests in TestSnapshotFromAdmin fail because that they are designed for the old synchronous implementation, which is polling result from server periodically, now we use a new implementation, which is blocking on the future until timeout. So I think we can move these two tests directly.

The two tests for testing AsyncFlushSnapshot fail because that we always choose to using SnapshotProcedure to take snapshot. If SnapshotProcedure is enabled, master will run a SnapshotProcedure and return a procid to the client, then the client will pull result by the procid. If SnapshotProcedure is disabled, then master will take a zk-coordinated snapshot and the client will keep asking master if the snapshot is finished by calling isSnapshotDone method. So The isSnapshotDone method is only used for zk-coordinated snapshots but in these two tests, we actually run a SnapshotProcedure, which will trigger an UnknownSnapshotException. I'll try to fix these problems as soon as possible.

The last failing test org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster.testSnapshotHFileArchiving is not very stable. I haven't find the reason why it failed yet. I'll keep trying.

Thanks.

Apache-HBase · 2022-03-16T16:15:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 35s	branch-2 passed
+1 💚	compile	1m 7s	branch-2 passed
+1 💚	shadedjars	0m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 22s	the patch passed
+1 💚	compile	1m 7s	the patch passed
+1 💚	javac	1m 7s	the patch passed
+1 💚	shadedjars	0m 21s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 48s	hbase-client in the patch passed.
-1 ❌	unit	10m 12s	hbase-server in the patch failed.
		24m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 25f294738d9a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `26af3b9`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/testReport/
Max. process+thread count	639 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T16:16:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 5s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 52s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 28s	branch-2 passed
+1 💚	compile	1m 0s	branch-2 passed
+1 💚	shadedjars	0m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 30s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	0m 23s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 47s	hbase-client in the patch passed.
-1 ❌	unit	10m 51s	hbase-server in the patch failed.
		26m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c665832573d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `26af3b9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/testReport/
Max. process+thread count	563 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-16T16:49:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 49s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 12s	branch-2 passed
+1 💚	compile	6m 18s	branch-2 passed
+1 💚	checkstyle	1m 44s	branch-2 passed
+1 💚	spotbugs	4m 32s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	6m 3s	the patch passed
+1 💚	javac	1m 25s	hbase-client generated 0 new + 158 unchanged - 1 fixed = 158 total (was 159)
+1 💚	javac	4m 39s	hbase-server in the patch passed.
+1 💚	checkstyle	0m 35s	hbase-client: The patch generated 0 new + 126 unchanged - 1 fixed = 126 total (was 127)
-0 ⚠️	checkstyle	1m 9s	hbase-server: The patch generated 10 new + 32 unchanged - 1 fixed = 42 total (was 33)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 36s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	4m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		58m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux a8aa0f071e7e 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `26af3b9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

frostruan · 2022-03-17T03:57:33Z

It looks like the unit tests failed because we set java.io.tmpdir to a relative path on mvn command when running jenkins job in HBASE-26848. I tried to set java.io.tmpdir to an absolute path when running local tests on my computer and it worked.

I am not sure what should I do about this problem. Would you mind giving me some suggestions? @Apache9

Thanks.

Apache9 · 2022-03-17T04:40:08Z

I'm currently working on solve the problem.

Will kick a new build after the problem is solved.

frostruan · 2022-03-17T04:41:24Z

Thanks, Duo.

Apache-HBase · 2022-03-17T06:22:21Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 45s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 5s	branch-2 passed
+1 💚	compile	7m 46s	branch-2 passed
+1 💚	checkstyle	2m 14s	branch-2 passed
+1 💚	spotbugs	6m 9s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 24s	the patch passed
+1 💚	compile	8m 40s	the patch passed
+1 💚	javac	1m 57s	hbase-client generated 0 new + 158 unchanged - 1 fixed = 158 total (was 159)
+1 💚	javac	6m 43s	hbase-server in the patch passed.
+1 💚	checkstyle	0m 47s	hbase-client: The patch generated 0 new + 126 unchanged - 1 fixed = 126 total (was 127)
-0 ⚠️	checkstyle	1m 45s	hbase-server: The patch generated 10 new + 32 unchanged - 1 fixed = 42 total (was 33)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	17m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	5m 36s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 38s	The patch does not generate ASF License warnings.
		73m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 18ad9dc13461 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b5d5fe8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-17T08:24:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 22s	branch-2 passed
+1 💚	compile	1m 7s	branch-2 passed
+1 💚	shadedjars	0m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	1m 6s	the patch passed
+1 💚	javac	1m 6s	the patch passed
+1 💚	shadedjars	0m 20s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 54s	hbase-client in the patch passed.
-1 ❌	unit	181m 11s	hbase-server in the patch failed.
		195m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux dc6bfdf50b90 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `b5d5fe8`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/testReport/
Max. process+thread count	2636 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-17T16:10:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 47s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 20s	Maven dependency ordering for branch
+1 💚	mvninstall	2m 45s	branch-2 passed
+1 💚	compile	3m 47s	branch-2 passed
+1 💚	checkstyle	1m 5s	branch-2 passed
+1 💚	spotbugs	2m 24s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s	the patch passed
+1 💚	compile	3m 14s	the patch passed
+1 💚	javac	0m 48s	hbase-client generated 0 new + 158 unchanged - 1 fixed = 158 total (was 159)
+1 💚	javac	2m 26s	hbase-server in the patch passed.
+1 💚	checkstyle	0m 22s	hbase-client: The patch generated 0 new + 126 unchanged - 1 fixed = 126 total (was 127)
-0 ⚠️	checkstyle	0m 43s	hbase-server: The patch generated 10 new + 32 unchanged - 1 fixed = 42 total (was 33)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	8m 33s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 50s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		36m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 277d621c0173 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81398f9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-17T19:10:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 55s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 8s	branch-2 passed
+1 💚	compile	1m 12s	branch-2 passed
+1 💚	shadedjars	0m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	0m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 6s	hbase-client in the patch passed.
+1 💚	unit	199m 0s	hbase-server in the patch passed.
		215m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3d4f9edfd842 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81398f9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/testReport/
Max. process+thread count	3006 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-17T20:06:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 14s	branch-2 passed
+1 💚	compile	1m 15s	branch-2 passed
+1 💚	shadedjars	0m 29s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	1m 14s	the patch passed
+1 💚	javac	1m 14s	the patch passed
+1 💚	shadedjars	0m 30s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 56s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 13s	hbase-client in the patch passed.
+1 💚	unit	252m 19s	hbase-server in the patch passed.
		272m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4225
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 15f865eb9954 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `81398f9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/testReport/
Max. process+thread count	2601 (vs. ulimit of 12500)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4225/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Closes #4225 Signed-off-by: Duo Zhang <[email protected]>

Apache9 · 2022-03-18T09:35:07Z

Pushed to branch-2 after fixing the checkstyle issues.

huiruan added 2 commits March 15, 2022 19:08

seperate TestSnapshotProcedure into some smaller tests

c0debf0

HBASE-26842 fix TestSnapshotProcedure for branch-2

8f5dffa

Apache9 approved these changes Mar 15, 2022

View reviewed changes

fix failed unit tests

7f7f5ad

Apache9 pushed a commit that referenced this pull request Mar 18, 2022

HBASE-26842 TestSnapshotProcedure fails in branch-2 (#4225)

4a6ba11

Closes #4225 Signed-off-by: Duo Zhang <[email protected]>

Apache9 closed this Mar 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26842 fix TestSnapshotProcedure for branch-2 #4225

HBASE-26842 fix TestSnapshotProcedure for branch-2 #4225

frostruan commented Mar 15, 2022

Apache9 left a comment

frostruan commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

frostruan commented Mar 15, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

frostruan commented Mar 17, 2022

Apache9 commented Mar 17, 2022

frostruan commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache9 commented Mar 18, 2022

HBASE-26842 fix TestSnapshotProcedure for branch-2 #4225

HBASE-26842 fix TestSnapshotProcedure for branch-2 #4225

Conversation

frostruan commented Mar 15, 2022

Apache9 left a comment

Choose a reason for hiding this comment

frostruan commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

Apache-HBase commented Mar 15, 2022

frostruan commented Mar 15, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

Apache-HBase commented Mar 16, 2022

frostruan commented Mar 17, 2022

Apache9 commented Mar 17, 2022

frostruan commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache-HBase commented Mar 17, 2022

Apache9 commented Mar 18, 2022