Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master #4221

ndimiduk · 2022-03-14T16:09:44Z

No description provided.

...dpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpointTracing.java

Apache-HBase · 2022-03-18T16:03:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 12s	master passed
+1 💚	compile	2m 59s	master passed
+1 💚	checkstyle	0m 48s	master passed
+1 💚	spotbugs	1m 50s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 2s	the patch passed
+1 💚	compile	2m 57s	the patch passed
+1 💚	javac	2m 57s	the patch passed
+1 💚	checkstyle	0m 47s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	2m 9s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		37m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4221
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e4d0015e639d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `520ad63`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server hbase-endpoint hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-18T18:58:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 53s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 48s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 10s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	4m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 47s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 22s	the patch passed
+1 💚	compile	1m 11s	the patch passed
+1 💚	javac	1m 11s	the patch passed
+1 💚	shadedjars	4m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 44s	the patch passed
		_ Other Tests _
+1 💚	unit	182m 54s	hbase-server in the patch passed.
+1 💚	unit	4m 7s	hbase-endpoint in the patch passed.
+1 💚	unit	0m 47s	hbase-it in the patch passed.
		212m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4221
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e6d25b3f6f4e 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `520ad63`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/testReport/
Max. process+thread count	3154 (vs. ulimit of 30000)
modules	C: hbase-server hbase-endpoint hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-18T19:02:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 7s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	4m 15s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	shadedjars	4m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	185m 44s	hbase-server in the patch passed.
+1 💚	unit	4m 7s	hbase-endpoint in the patch passed.
+1 💚	unit	0m 52s	hbase-it in the patch passed.
		216m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4221
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 78c3a9a6b357 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `520ad63`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/testReport/
Max. process+thread count	2801 (vs. ulimit of 30000)
modules	C: hbase-server hbase-endpoint hbase-it U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4221/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2022-03-21T11:08:02Z

Do you have any further comments @Apache9 ? Here, or on #4220 ?

ndimiduk · 2022-03-21T11:41:30Z

Thanks @Apache9

ndimiduk added the backport This PR is a back port of some issue or issues already committed to master label Mar 14, 2022

ndimiduk mentioned this pull request Mar 14, 2022

HBASE-26834 Adapt ConnectionRule for both sync and async connections (branch-2) #4220

Merged

This comment was marked as outdated.

Sign in to view

Apache9 reviewed Mar 15, 2022

View reviewed changes

...dpoint/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpointTracing.java Outdated Show resolved Hide resolved

ndimiduk added 2 commits March 16, 2022 13:33

HBASE-26834 Adapt ConnectionRule for both sync and async connections

297bc30

PR Feedback

c2a8978

ndimiduk force-pushed the 26834-connectionrule-sync-async branch from 71aba4c to c2a8978 Compare March 16, 2022 12:42

This comment was marked as outdated.

Sign in to view

ndimiduk requested a review from Apache9 March 17, 2022 15:07

Apache9 approved these changes Mar 21, 2022

View reviewed changes

ndimiduk merged commit f78f232 into apache:master Mar 21, 2022

ndimiduk deleted the 26834-connectionrule-sync-async branch March 21, 2022 11:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master #4221

Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master #4221

ndimiduk commented Mar 14, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 18, 2022

Apache-HBase commented Mar 18, 2022

Apache-HBase commented Mar 18, 2022

ndimiduk commented Mar 21, 2022

ndimiduk commented Mar 21, 2022

Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master #4221

Forward-port "HBASE-26834 Adapt ConnectionRule for both sync and async connections" to master #4221

Conversation

ndimiduk commented Mar 14, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Apache-HBase commented Mar 18, 2022

Apache-HBase commented Mar 18, 2022

Apache-HBase commented Mar 18, 2022

ndimiduk commented Mar 21, 2022

ndimiduk commented Mar 21, 2022