Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

HBASE-26630 TableSnapshotInputFormat terminates in the middle #4215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@ public ClientSideRegionScanner(Configuration conf, FileSystem fs,
@Override
public Result next() throws IOException {
values.clear();
scanner.nextRaw(values);
if (values.isEmpty()) {
//we are done
boolean moreValues;
do {
moreValues = scanner.nextRaw(values);
} while (values.isEmpty() && moreValues);

if (!moreValues) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will see empty result (values) but still more rows when the scan met RPC timeout value? Will it be possible to have UT here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scan is not an RPC timeout situation. After scannerContext.returnImmediately() is called in storeScanner, it is returned as true by scannerContext.checkTimeLimit(limitScope) in RegionScannerImpl.

https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java#L563

return null;
}

Expand Down