Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26814 Addendum: Fix spotbugs warning and clarify intent #4201

Merged
merged 1 commit into from
Mar 10, 2022
Merged

HBASE-26814 Addendum: Fix spotbugs warning and clarify intent #4201

merged 1 commit into from
Mar 10, 2022

Conversation

bbeaudreault
Copy link
Contributor

@bbeaudreault bbeaudreault mentioned this pull request Mar 10, 2022
Merged
@bbeaudreault
Copy link
Contributor Author

I can't seem to get spotbugs to run locally in a useful way to verify this fix. I've tried various different permutations of mvn spotbugs:spotbugs, spotbugs:check, etc. We'll see what precommit check shows, but it didn't catch the original. If someone has a one-liner I can run I'd be happy to give it a shot

@ndimiduk
Copy link
Member

You can look in the BlueOcean output of the General Checks to find it. The incantation looks like

[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1105)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1106)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1107)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1108)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1109)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1110)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1111)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1112)[](https://ci-hbase.apache.org/blue/organizations/jenkins/HBase-PreCommit-GitHub-PR/detail/PR-4196/1/#step-87-log-1113)[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z]                       spotbugs detection: branch-2.5
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] ============================================================================
[2022-03-10T13:54:26.637Z] 
[2022-03-10T13:54:26.637Z] 
[2022-03-10T13:54:26.637Z] [Thu Mar 10 13:54:19 UTC 2022 INFO]: Personality: branch spotbugs
[2022-03-10T13:54:26.637Z] cd /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-general-check/src/hbase-server
[2022-03-10T13:54:26.637Z] /opt/maven/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-m2/hbase-branch-2.5-patch-1 --threads=2 -DHBasePatchProcess test-compile spotbugs:spotbugs -DskipTests=true > /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-4196/yetus-general-check/output/branch-spotbugs-hbase-server.txt 2>&1

ndimiduk
ndimiduk approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me.

@apurtell
Copy link
Contributor

When we cherry pick obviously spotbugs doesn't run. I do run unit tests locally, but this will vary by individual. It is interesting that the settings might be different per branch.

@apurtell apurtell merged commit 4da53ef into apache:master Mar 10, 2022
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 4s #4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #4201
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console
versions git=2.25.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 7s Docker mode activated.
-1 ❌ patch 0m 3s #4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4201
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 3s #4201 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #4201
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4201/1/console
versions git=2.25.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

asfgit pushed a commit that referenced this pull request Mar 10, 2022
@bbeaudreault @apurtell
HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201)
fac011e 
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Andrew Purtell <[email protected]>
asfgit pushed a commit that referenced this pull request Mar 10, 2022
@bbeaudreault @apurtell
HBASE-26814 Addendum: Fix spotbugs warning and clarify intent (#4201)
1f9e5a1 
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Andrew Purtell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apurtell apurtell apurtell approved these changes

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbeaudreault @ndimiduk @apurtell @Apache-HBase