-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26804 Missing opentelemetry agent in hadoop-two-compat.xml #4185
Conversation
see the original commit in master here 8d2a0ef and this PR is porting the change in hadoop-three-compat.xml to hadoop-two-compat.xml |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right to me. I don't have a simple means of testing it, can I assume you've got that covered, @taklwu ?
I had an internal runtime was using hadoop2 build client and bin. But for this PR, I checked if the jar exists within the tar.gz that should be proving the agent has been included as part of the classpath.
|
Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
No description provided.