HBASE-26680 Close and do not write trailer for the broken WAL writer #4174

sunhelly · 2022-03-07T12:11:21Z

Broken writers need to be closed, so that when doing log split, there will be no need to recover lease for those length 0 wals.

Apache-HBase · 2022-03-07T12:39:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 39s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	3m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 14s	root in the patch failed.
-1 ❌	compile	0m 27s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 27s	hbase-server in the patch failed.
-1 ❌	shadedjars	2m 39s	patch has 14 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 28s	hbase-server in the patch failed.
		13m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 8202abda3a52 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/testReport/
Max. process+thread count	52 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-07T12:41:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	2m 11s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotbugs	1m 14s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 5s	root in the patch failed.
-1 ❌	compile	0m 24s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 24s	hbase-server in the patch failed.
+1 💚	checkstyle	0m 31s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	hadoopcheck	1m 7s	The patch causes 14 errors with Hadoop v3.1.2.
-1 ❌	hadoopcheck	2m 18s	The patch causes 14 errors with Hadoop v3.2.2.
-1 ❌	hadoopcheck	3m 27s	The patch causes 14 errors with Hadoop v3.3.1.
-1 ❌	spotbugs	0m 17s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		14m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b6724e8056b6 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-07T12:42:47Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 47s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	4m 22s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	master passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	1m 23s	root in the patch failed.
-1 ❌	compile	0m 27s	hbase-server in the patch failed.
-0 ⚠️	javac	0m 27s	hbase-server in the patch failed.
-1 ❌	shadedjars	2m 53s	patch has 14 errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	the patch passed
		_ Other Tests _
-1 ❌	unit	0m 30s	hbase-server in the patch failed.
		17m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux af1b6344cd16 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-11.0.10+9
mvninstall	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
javac	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/testReport/
Max. process+thread count	69 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-07T13:40:05Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 17s	master passed
+1 💚	compile	2m 10s	master passed
+1 💚	checkstyle	0m 33s	master passed
+1 💚	spotbugs	1m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 18s	the patch passed
+1 💚	compile	2m 11s	the patch passed
+1 💚	javac	2m 11s	the patch passed
+1 💚	checkstyle	0m 34s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 31s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 17s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 7s	The patch does not generate ASF License warnings.
		29m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d7ac1888b415 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-07T18:55:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 58s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 3s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 39s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 48s	the patch passed
+1 💚	compile	0m 46s	the patch passed
+1 💚	javac	0m 46s	the patch passed
+1 💚	shadedjars	3m 36s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	326m 56s	hbase-server in the patch passed.
		344m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1738ed073039 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/testReport/
Max. process+thread count	3075 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-07T19:09:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 30s	master passed
+1 💚	compile	0m 37s	master passed
+1 💚	shadedjars	3m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	3m 35s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	342m 50s	hbase-server in the patch passed.
		359m 5s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 147c4c109ec1 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f3f2aa9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/testReport/
Max. process+thread count	2774 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9

Got your point.

But I suggest that we just close the output in the init method, the closeWithoutTrailer is a bit strange as we do not have other methods which indicate that there is trailer for the file?

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java

Apache-HBase · 2022-03-10T04:31:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 0s	master passed
+1 💚	compile	2m 48s	master passed
+1 💚	checkstyle	0m 41s	master passed
-1 ❌	spotbugs	1m 26s	hbase-server in master has 1 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	2m 26s	the patch passed
+1 💚	javac	2m 26s	the patch passed
+1 💚	checkstyle	0m 41s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 34s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 41s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		35m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 6c8170cfa7a5 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1057da8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
spotbugs	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-10T11:09:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	shadedjars	5m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	5m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	409m 23s	hbase-server in the patch failed.
		433m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c337faf927d3 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1057da8`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/testReport/
Max. process+thread count	2157 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-10T11:28:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	0m 45s	master passed
+1 💚	shadedjars	3m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
+1 💚	shadedjars	3m 33s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 25s	the patch passed
		_ Other Tests _
-1 ❌	unit	433m 25s	hbase-server in the patch failed.
		452m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 13b679108e9d 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1057da8`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/testReport/
Max. process+thread count	2894 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

sunhelly · 2022-03-11T03:48:46Z

Got your point.

But I suggest that we just close the output in the init method, the closeWithoutTrailer is a bit strange as we do not have other methods which indicate that there is trailer for the file?

Thanks, @Apache9 , good idea. I have closed the output in the init method.

Apache-HBase · 2022-03-11T04:30:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 20s	master passed
+1 💚	compile	2m 35s	master passed
+1 💚	checkstyle	0m 40s	master passed
+1 💚	spotbugs	1m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 43s	the patch passed
+1 💚	compile	2m 28s	the patch passed
+1 💚	javac	2m 28s	the patch passed
+1 💚	checkstyle	0m 39s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	hadoopcheck	12m 51s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 39s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		34m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux d3bb4d5282f9 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dbf5681`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	60 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/FSHLogProvider.java

Apache-HBase · 2022-03-11T09:28:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 19s	master passed
+1 💚	compile	0m 40s	master passed
+1 💚	shadedjars	3m 47s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 45s	the patch passed
+1 💚	compile	0m 42s	the patch passed
+1 💚	javac	0m 42s	the patch passed
+1 💚	shadedjars	3m 50s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	311m 29s	hbase-server in the patch passed.
		332m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0aa9e6e0120d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dbf5681`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/testReport/
Max. process+thread count	2509 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-11T09:33:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 21s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 31s	master passed
+1 💚	compile	0m 38s	master passed
+1 💚	shadedjars	3m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 23s	the patch passed
+1 💚	compile	0m 38s	the patch passed
+1 💚	javac	0m 38s	the patch passed
+1 💚	shadedjars	3m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	321m 59s	hbase-server in the patch passed.
		337m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c10d2e1b0d95 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `dbf5681`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/testReport/
Max. process+thread count	3030 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T13:58:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 40s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --quick-hadoopcheck --exclude-tests-url --asf-nightlies-general-check-base --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 9s	master passed
+1 💚	compile	0m 41s	master passed
+1 💚	checkstyle	0m 39s	master passed
+1 💚	spotbugs	1m 28s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 42s	the patch passed
+1 💚	compile	0m 41s	the patch passed
+1 💚	javac	0m 41s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
-0 ⚠️	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	spotbugs	1m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 6s	The patch does not generate ASF License warnings.
		12m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	dupname asflicense javac spotbugs checkstyle compile
uname	Linux 38cad9f7f644 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `36a5f86`
Default Java	AdoptOpenJDK-1.8.0_282-b08
whitespace	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-general-check/output/whitespace-eol.txt
Max. process+thread count	57 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T16:14:58Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 4s	master passed
+1 💚	compile	0m 49s	master passed
+1 💚	javadoc	0m 31s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	0m 52s	the patch passed
+1 💚	compile	0m 47s	the patch passed
+1 💚	javac	0m 47s	the patch passed
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
-1 ❌	unit	138m 33s	hbase-server in the patch failed.
		149m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit compile
uname	Linux 62fe0cb4a348 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `36a5f86`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/testReport/
Max. process+thread count	1928 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-03-14T17:04:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 18s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck --skip-errorprone --exclude-tests-url --build-thread --surefire-first-part-fork-count --surefire-second-part-fork-count
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 8s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 1s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	185m 15s	hbase-server in the patch failed.
		198m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4174
Optional Tests	javac javadoc unit compile
uname	Linux ba69ae2003cf 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `36a5f86`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/testReport/
Max. process+thread count	2123 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4174/6/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…4174) Signed-off-by: Duo Zhang <[email protected]>

…pache#4174) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 8cce0d3) Change-Id: I2514bda4a62089328ed5f561ef2b98798ec7d727

sunhelly force-pushed the HBASE-26680 branch from 0be356d to b6baf07 Compare March 7, 2022 12:56

sunhelly requested a review from Apache9 March 9, 2022 15:05

Apache9 reviewed Mar 10, 2022

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AsyncProtobufLogWriter.java Outdated Show resolved Hide resolved

sunhelly force-pushed the HBASE-26680 branch from fe729a9 to 932540d Compare March 11, 2022 03:37

sunhelly changed the title ~~HBASE-26680 Close the broken writer in AsyncFSWALProvider#createAsync…~~ HBASE-26680 Close and do not write trailer for the broken WAL writer Mar 11, 2022

HBASE-26680 Close and do not write trailer for the broken WAL writer

6145199

sunhelly force-pushed the HBASE-26680 branch from 932540d to 6145199 Compare March 11, 2022 03:47

GeorryHuang reviewed Mar 11, 2022

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/wal/FSHLogProvider.java Show resolved Hide resolved

add some description

d8b36b7

Apache9 approved these changes Mar 16, 2022

View reviewed changes

sunhelly merged commit c7773ad into apache:master Mar 16, 2022

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26680 Close and do not write trailer for the broken WAL writer (#…

8cce0d3

…4174) Signed-off-by: Duo Zhang <[email protected]>

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26680 Close and do not write trailer for the broken WAL writer (#…

e008cb8

…4174) Signed-off-by: Duo Zhang <[email protected]>

asfgit pushed a commit that referenced this pull request Mar 16, 2022

HBASE-26680 Close and do not write trailer for the broken WAL writer (#…

db5e954

…4174) Signed-off-by: Duo Zhang <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26680 Close and do not write trailer for the broken WAL writer #4174

HBASE-26680 Close and do not write trailer for the broken WAL writer #4174

sunhelly commented Mar 7, 2022 •

edited

Loading

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache9 left a comment

Apache-HBase commented Mar 10, 2022

Apache-HBase commented Mar 10, 2022

Apache-HBase commented Mar 10, 2022

sunhelly commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

HBASE-26680 Close and do not write trailer for the broken WAL writer #4174

HBASE-26680 Close and do not write trailer for the broken WAL writer #4174

Conversation

sunhelly commented Mar 7, 2022 • edited Loading

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache-HBase commented Mar 7, 2022

Apache9 left a comment

Choose a reason for hiding this comment

Apache-HBase commented Mar 10, 2022

Apache-HBase commented Mar 10, 2022

Apache-HBase commented Mar 10, 2022

sunhelly commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 11, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

Apache-HBase commented Mar 14, 2022

sunhelly commented Mar 7, 2022 •

edited

Loading