-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-26802 Backport the log4j2 changes to branch-2 #4166
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Let me try to execute the UTs locally to see what is the problem. Seems we always hit the timeout. |
@@ -96,11 +96,6 @@ protected static void startMiniDFSCluster(int servers) throws IOException { | |||
createDirsAndSetProperties(); | |||
|
|||
Configuration conf = UTIL.getConfiguration(); | |||
// Error level to skip some warnings specific to the minicluster. See HBASE-4709 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good cleanup.
Could also use the Log4JUtils static helpers.
The changes lgtm, good to commit once the test issues are analyzed and resolved. |
Thanks @apurtell for the detailed review. Let me address the problems. |
Running locally, we hang forever when running TestThriftServerCmdLine. Not sure why it did not timeout. Will dig more and report back later. |
Oh, it is just a bind error, tried another round it passed... |
4f3d950
to
b51ed45
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
Signed-off-by: Andrew Purtell <[email protected]> Conflicts: hbase-hadoop-compat/pom.xml hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java hbase-shaded/hbase-shaded-client-byo-hadoop/pom.xml hbase-shaded/hbase-shaded-client/pom.xml hbase-shaded/hbase-shaded-mapreduce/pom.xml hbase-shaded/hbase-shaded-testing-util/pom.xml hbase-shaded/pom.xml hbase-testing-util/pom.xml
No description provided.