-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22743 : ClientUtils for Demo Client classes #413
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
bd03f96
to
bcb4795
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
* @return UTF8 decoded string value | ||
*/ | ||
public static String utf8(byte[] buf) { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use the Bytes.toString ? I think it have considered the utf8 decode.
public static String toString(final byte [] b) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Please review
* Common Utility class for clients | ||
*/ | ||
@InterfaceAudience.Private | ||
public class ClientUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the class to be final ?
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
(cherry picked from commit a424ed1) Change-Id: I3a4d0ae69e7a4ae15c3809494e75c00b56eeea16
No description provided.