HBASE-26741 Incorrect exception handling in shell #4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Override eval_input in HIRB to modify exception handling logic.
|
where's the specific line this is copied from? we'll need to attribute and update LICENSE info. |
|
what does this behavior look like during the default interactive mode? |
Copied this method with a single line change: https://github.com/jruby/jruby/blob/9.2.13.0/lib/ruby/stdlib/irb.rb#L440-L537 |
|
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
non-interactive mode with exception: non-interactive without exceptions and non-zero exit code: |
|
🎊 +1 overall
This message was automatically generated. |
joshelser
reviewed
Feb 8, 2022
There was a problem hiding this comment.
I would love to see the comment expanded and a unit test to cover this, too.
JRuby appears to be 2-clause bsd (assuming BSDL is not unique to the standard BSD license...)
JRuby distributes some ruby modules which are distributed under Ruby
license:
Ruby is copyrighted free software by Yukihiro Matsumoto <[email protected]>.
You can redistribute it and/or modify it under either the terms of the
2-clause BSDL (see the file BSDL), or the conditions below:
...
Co-authored-by: Josh Elser <[email protected]>
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
The irb.rb file (and the duplicated method) is originally from Ruby and not JRuby: https://github.com/ruby/irb/blob/9d7ba836eb1ec8ec71b6a24e9683ba96fe3fb72b/lib/irb.rb#L441-L537 This repository is using BSD 2-Clause which is a Category A license by ASF policies: https://www.apache.org/legal/resolved.html#category-a
I'm not yet sure how to do that. We have existing tests for shell command execution throwing exception in non-interactive mode but these tests don't use IRB.run underneath. |
|
Manual testing shows these results, matching the behavior of HBase 2.2.7.
|
|
🎊 +1 overall
This message was automatically generated. |
|
what happens to stuff that comes from stdin in non-interactive mode? (in 2.2 and with this patch) |
The behavior is identical. Both quits on exceptions with exit code 1. |
joshelser
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
This is breaking stuff downstream that we'd like to get fixed (sadly, urgently), so I'm +1 to fix the immediate problem and then follow-up a unit-test to codify the expected functionality.
Shout if you're not OK with that @busbey
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
added a commit
that referenced
this pull request
Feb 10, 2022
Override eval_input in HIRB to modify exception handling logic. Signed-off-by: Josh Elser <[email protected]>
petersomogyi
added a commit
that referenced
this pull request
Feb 10, 2022
Override eval_input in HIRB to modify exception handling logic. Signed-off-by: Josh Elser <[email protected]>
petersomogyi
added a commit
that referenced
this pull request
Feb 10, 2022
Override eval_input in HIRB to modify exception handling logic. Signed-off-by: Josh Elser <[email protected]>
vinayakphegde
pushed a commit
to vinayakphegde/hbase
that referenced
this pull request
Apr 4, 2024
Override eval_input in HIRB to modify exception handling logic. Signed-off-by: Josh Elser <[email protected]> (cherry picked from commit 3994374) Change-Id: Ifa97cbbe6a53c7f0ccece36ebb66c6a91b844088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override eval_input in HIRB to modify exception handling logic.