Backport "HBASE-26614 Refactor code related to "dump"ing ZK nodes (#3969)" to branch-2

[ndimiduk]

The code starting at ZKUtil.dump(ZKWatcher) is a small mess – it has cyclic dependencies woven
through itself, ZKWatcher and RecoverableZooKeeper. It also initializes a static variable in
ZKUtil through the factory for RecoverableZooKeeper instances. Let's decouple and clean it
up.

Signed-off-by: Duo Zhang [email protected]
Signed-off-by: Josh Elser [email protected]

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 40s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 11s	branch-2 passed
+1 💚	compile	4m 59s	branch-2 passed
+1 💚	checkstyle	1m 54s	branch-2 passed
+1 💚	spotbugs	3m 22s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	4m 58s	the patch passed
-0 ⚠️	javac	0m 28s	hbase-zookeeper generated 5 new + 105 unchanged - 6 fixed = 110 total (was 111)
+1 💚	checkstyle	1m 52s	the patch passed
+1 💚	rubocop	0m 9s	There were no new rubocop issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	14m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	3m 56s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 49s	The patch does not generate ASF License warnings.
		56m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4058
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile rubocop
uname	Linux 7302fece58a1 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5aa0fd2
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-zookeeper.txt
Max. process+thread count	86 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2 rubocop=0.80.0
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 7s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 43s	branch-2 passed
+1 💚	compile	2m 37s	branch-2 passed
+1 💚	shadedjars	8m 27s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 42s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	2m 29s	the patch passed
+1 💚	javac	2m 29s	the patch passed
+1 💚	shadedjars	7m 37s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 49s	hbase-zookeeper in the patch passed.
+1 💚	unit	136m 15s	hbase-server in the patch passed.
+1 💚	unit	7m 11s	hbase-shell in the patch passed.
+1 💚	unit	1m 12s	hbase-it in the patch passed.
		183m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4058
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 66c70133a83c 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5aa0fd2
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/testReport/
Max. process+thread count	4343 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 6s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 50s	branch-2 passed
+1 💚	compile	2m 13s	branch-2 passed
+1 💚	shadedjars	6m 35s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 27s	branch-2 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	2m 15s	the patch passed
+1 💚	javac	2m 15s	the patch passed
+1 💚	shadedjars	6m 34s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 45s	hbase-zookeeper in the patch passed.
+1 💚	unit	155m 33s	hbase-server in the patch passed.
+1 💚	unit	7m 20s	hbase-shell in the patch passed.
+1 💚	unit	1m 17s	hbase-it in the patch passed.
		197m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#4058
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b8dde8ca488b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / 5aa0fd2
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/testReport/
Max. process+thread count	3762 (vs. ulimit of 12500)
modules	C: hbase-zookeeper hbase-server hbase-shell hbase-it U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4058/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.