HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. #4048

YutSean · 2022-01-20T03:47:05Z

https://issues.apache.org/jira/browse/HBASE-26688

…created EMPTY_RESULT like objects can be shared by multi client threads.

Apache-HBase · 2022-01-20T04:19:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 49s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	8m 30s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 30s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 33s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	8m 19s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 28s	hbase-client in the patch passed.
		31m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 10d28e3acb91 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/testReport/
Max. process+thread count	308 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-20T04:22:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	10m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 43s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	9m 56s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 22s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 30s	hbase-client in the patch passed.
		34m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 40862aacdfb6 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/testReport/
Max. process+thread count	348 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-20T04:30:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 14s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	checkstyle	0m 30s	master passed
+1 💚	spotbugs	1m 5s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
-0 ⚠️	checkstyle	0m 29s	hbase-client: The patch generated 2 new + 11 unchanged - 2 fixed = 13 total (was 13)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 45s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		42m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 643bf89ca07b 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-20T09:28:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 11s	master passed
+1 💚	compile	0m 27s	master passed
+1 💚	shadedjars	8m 19s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 56s	the patch passed
+1 💚	compile	0m 27s	the patch passed
+1 💚	javac	0m 27s	the patch passed
+1 💚	shadedjars	8m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 19s	hbase-client in the patch passed.
		29m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 872c58e2a6ca 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/
Max. process+thread count	341 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-20T09:30:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 52s	master passed
+1 💚	compile	0m 31s	master passed
+1 💚	shadedjars	8m 24s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 37s	the patch passed
+1 💚	compile	0m 31s	the patch passed
+1 💚	javac	0m 31s	the patch passed
+1 💚	shadedjars	8m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 27s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
		31m 9s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6c9f8f7b8a60 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/testReport/
Max. process+thread count	301 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2022-01-20T09:40:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	checkstyle	0m 28s	master passed
+1 💚	spotbugs	1m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s	the patch passed
+1 💚	compile	0m 57s	the patch passed
+1 💚	javac	0m 57s	the patch passed
+1 💚	checkstyle	0m 28s	hbase-client: The patch generated 0 new + 11 unchanged - 2 fixed = 11 total (was 13)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 29s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		41m 37s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#4048
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 8261bf61cd2c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1d2b8a0`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4048/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2022-01-24T11:44:25Z

Better use a new title for the issue? The actual change seems not related to the title...

YutSean · 2022-01-24T12:14:38Z

Yeah...... The previous description is a little bit imprecise. Has fixed. @Apache9

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

bbeaudreault · 2022-01-25T20:07:10Z

It's weird that this build succeeded. I'm seeing failures in master in TestResult#testAdvanceTwiceOnEmptyCell which look legit. The test expects to catch a NoSuchElementException, but that will never be thrown now that the new isEmpty() check short circuits advance().

…d client job down. (#4048)" This reverts commit d77ede4.

…d client job down. (#4048)" This reverts commit 087bb13.

…d client job down. (#4048)" This reverts commit 0771c04.

…d client job down. (#4048)" This reverts commit fbd22f0.

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

… job down. (apache#4048) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit fbd22f0) Change-Id: I89bb6e991178b65e503988d8675eb0a19d9ee39f

…d client job down. (apache#4048)" This reverts commit fbd22f0. (cherry picked from commit 0af543c) Change-Id: Ibd551e46e0bb88aca8f40d71fbb0cabacd2ab735

HBASE-26688 Result#advance, current are not thread safe. But the pre-…

6a1fba9

…created EMPTY_RESULT like objects can be shared by multi client threads.

Checkstyle fix

917bd91

YutSean changed the title ~~HBASE-26688 Result#advance, current are not thread safe. But the precreated EMPTY_RESULT like objects can be shared by multi client threads.~~ HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. Jan 24, 2022

Apache9 approved these changes Jan 25, 2022

View reviewed changes

Apache9 merged commit d77ede4 into apache:master Jan 25, 2022

Apache9 pushed a commit that referenced this pull request Jan 25, 2022

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…

087bb13

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

Apache9 pushed a commit that referenced this pull request Jan 25, 2022

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…

0771c04

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

Apache9 pushed a commit that referenced this pull request Jan 25, 2022

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…

fbd22f0

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

Apache9 added a commit that referenced this pull request Jan 26, 2022

Revert "HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpecte…

c33fa3a

…d client job down. (#4048)" This reverts commit d77ede4.

Apache9 added a commit that referenced this pull request Jan 26, 2022

Revert "HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpecte…

0ca2307

…d client job down. (#4048)" This reverts commit 087bb13.

Apache9 added a commit that referenced this pull request Jan 26, 2022

Revert "HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpecte…

7e84223

…d client job down. (#4048)" This reverts commit 0771c04.

Apache9 added a commit that referenced this pull request Jan 26, 2022

Revert "HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpecte…

0af543c

…d client job down. (#4048)" This reverts commit fbd22f0.

asfgit pushed a commit that referenced this pull request Mar 11, 2022

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client…

44cae8f

… job down. (#4048) Signed-off-by: Duo Zhang <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. #4048

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. #4048

YutSean commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache9 commented Jan 24, 2022

YutSean commented Jan 24, 2022 •

edited

Loading

bbeaudreault commented Jan 25, 2022 •

edited

Loading

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. #4048

HBASE-26688 Threads shared EMPTY_RESULT may lead to unexpected client job down. #4048

Conversation

YutSean commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache-HBase commented Jan 20, 2022

Apache9 commented Jan 24, 2022

YutSean commented Jan 24, 2022 • edited Loading

bbeaudreault commented Jan 25, 2022 • edited Loading

YutSean commented Jan 24, 2022 •

edited

Loading

bbeaudreault commented Jan 25, 2022 •

edited

Loading