Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26520 Remove use of db.hbase.namespance tracing attribute #4015

Conversation

ndimiduk
Copy link
Member

@ndimiduk ndimiduk commented Jan 6, 2022

The HBase-specific attribute db.hbase.namespace has been deprecated in favor of the generic
db.name. See also open-telemetry/opentelemetry-specification#1760

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760
@ndimiduk ndimiduk requested review from taklwu and Apache9 January 6, 2022 22:36
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 15s Maven dependency ordering for branch
+1 💚 mvninstall 4m 26s master passed
+1 💚 compile 0m 50s master passed
+1 💚 shadedjars 9m 7s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 4m 18s the patch passed
+1 💚 compile 0m 52s the patch passed
+1 💚 javac 0m 52s the patch passed
+1 💚 shadedjars 9m 8s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 42s the patch passed
_ Other Tests _
+1 💚 unit 2m 5s hbase-common in the patch passed.
+1 💚 unit 1m 40s hbase-client in the patch passed.
37m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4015
Optional Tests javac javadoc unit shadedjars compile
uname Linux b07f19570d6f 4.15.0-162-generic #170-Ubuntu SMP Mon Oct 18 11:38:05 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7972b2e
Default Java AdoptOpenJDK-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/testReport/
Max. process+thread count 227 (vs. ulimit of 30000)
modules C: hbase-common hbase-client U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 6m 31s master passed
+1 💚 compile 1m 9s master passed
+1 💚 shadedjars 10m 16s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 0s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 6m 2s the patch passed
+1 💚 compile 1m 7s the patch passed
+1 💚 javac 1m 7s the patch passed
+1 💚 shadedjars 10m 11s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 57s the patch passed
_ Other Tests _
+1 💚 unit 2m 33s hbase-common in the patch passed.
+1 💚 unit 1m 59s hbase-client in the patch passed.
46m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4015
Optional Tests javac javadoc unit shadedjars compile
uname Linux ed7e17637cfe 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7972b2e
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/testReport/
Max. process+thread count 211 (vs. ulimit of 30000)
modules C: hbase-common hbase-client U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 28s master passed
+1 💚 compile 1m 44s master passed
+1 💚 checkstyle 0m 53s master passed
+1 💚 spotbugs 1m 49s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 4m 20s the patch passed
+1 💚 compile 1m 44s the patch passed
+1 💚 javac 1m 44s the patch passed
+1 💚 checkstyle 0m 52s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 21m 34s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚 spotbugs 2m 10s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
51m 31s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4015
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 8430db17e729 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 7972b2e
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-common hbase-client U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4015/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 9f47ab5 into apache:master Jan 11, 2022
@ndimiduk ndimiduk deleted the 26520-tracing-remove-db.hbase.namespace-attribute branch January 11, 2022 01:02
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 18, 2022
…ache#4015)

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 18, 2022
…ache#4015)

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
ndimiduk added a commit that referenced this pull request Jan 19, 2022
)

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Jan 19, 2022
…ache#4015)

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
ndimiduk added a commit that referenced this pull request Jan 24, 2022
)

The HBase-specific attribute `db.hbase.namespace` has been deprecated in favor of the generic
`db.name`. See also open-telemetry/opentelemetry-specification#1760

Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants