HBASE-26471 Move tracing semantic attributes to their own class #3896

ndimiduk · 2021-11-29T21:41:09Z

No description provided.

Apache9 · 2021-11-30T04:29:51Z

Please fix the checkstyle issue?

Thanks.

taklwu · 2021-11-30T15:37:43Z

hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseSemanticAttributes.java

+*/
+@InterfaceAudience.Private
+public final class HBaseSemanticAttributes {
+  public static final AttributeKey<String> NAMESPACE_KEY = SemanticAttributes.DB_HBASE_NAMESPACE;


[nit] seems like they have deprecated SemanticAttributes.DB_HBASE_NAMESPACE after opentelemetry 1.8.0, and they ask user to use a generic variable of SemanticAttributes#DB_NAME, for long term, what should it be ?

nvm, although I'm confused with their versioning now, I found their v1.9.1 still have this variable, if you have a chance, can you reach out and ask them before pushing ?

It seems their intent is to drop these system-specific attributes in favor of the generic attribute. Sure, I'll ask.

https://cloud-native.slack.com/archives/C0150QF88FL/p1638287586272800

FYI, the next patch will introduce use of the attribute db.name: 84ea8e2#diff-aac65169b0283bbffad891c962709e203e22d6a5170d160ab72ee9e9f6cbbe3cR31

Apache-HBase · 2021-11-30T19:21:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 12s	master passed
+1 💚	compile	5m 2s	master passed
+1 💚	checkstyle	2m 2s	master passed
+1 💚	spotbugs	3m 54s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 16s	the patch passed
+1 💚	compile	5m 3s	the patch passed
-0 ⚠️	javac	3m 21s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚	checkstyle	2m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
+1 💚	spotbugs	4m 30s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 33s	The patch does not generate ASF License warnings.
		63m 49s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3896
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux cbe8502a0b63 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-30T21:35:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 35s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 10s	master passed
+1 💚	compile	2m 22s	master passed
+1 💚	shadedjars	9m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 44s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 39s	the patch passed
+1 💚	compile	2m 15s	the patch passed
+1 💚	javac	2m 15s	the patch passed
+1 💚	shadedjars	8m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 6s	hbase-common in the patch passed.
+1 💚	unit	1m 37s	hbase-client in the patch passed.
+1 💚	unit	153m 21s	hbase-server in the patch passed.
		197m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3896
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 95696e9e513e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/testReport/
Max. process+thread count	3725 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-11-30T23:06:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 25s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 3s	master passed
+1 💚	compile	2m 17s	master passed
+1 💚	shadedjars	10m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 41s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 53s	the patch passed
+1 💚	compile	2m 16s	the patch passed
+1 💚	javac	2m 16s	the patch passed
+1 💚	shadedjars	10m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 36s	hbase-common in the patch passed.
+1 💚	unit	1m 51s	hbase-client in the patch passed.
+1 💚	unit	241m 6s	hbase-server in the patch passed.
		288m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3896
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ff7951ab5be8 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f108997`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/testReport/
Max. process+thread count	2964 (vs. ulimit of 30000)
modules	C: hbase-common hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3896/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk · 2021-12-01T17:18:47Z

CI failure is a failure of the build infrastructure, not the patch.

…he#3896) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>

Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>

HBASE-26471 Move tracing semantic attributes to their own class

acd01d0

ndimiduk requested review from taklwu and Apache9 November 29, 2021 21:41

This comment has been minimized.

Sign in to view

Apache9 approved these changes Nov 30, 2021

View reviewed changes

fix checkstyle nits

b500e85

taklwu reviewed Nov 30, 2021

View reviewed changes

taklwu approved these changes Nov 30, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

fix checkstyle nits

70f6af4

This comment has been minimized.

Sign in to view

ndimiduk merged commit ea824df into apache:master Dec 1, 2021

ndimiduk deleted the 26471-semantic-attributes-own-class branch December 1, 2021 17:21

ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Dec 1, 2021

HBASE-26471 Move tracing semantic attributes to their own class (apac…

43f430d

…he#3896) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>

ndimiduk added a commit that referenced this pull request Dec 1, 2021

HBASE-26471 Move tracing semantic attributes to their own class (#3896)

d1c68a2

Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-26471 Move tracing semantic attributes to their own class #3896

HBASE-26471 Move tracing semantic attributes to their own class #3896

ndimiduk commented Nov 29, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache9 commented Nov 30, 2021

taklwu Nov 30, 2021 •

edited

Loading

taklwu Nov 30, 2021

ndimiduk Nov 30, 2021

ndimiduk Nov 30, 2021

ndimiduk Nov 30, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

ndimiduk commented Dec 1, 2021

HBASE-26471 Move tracing semantic attributes to their own class #3896

HBASE-26471 Move tracing semantic attributes to their own class #3896

Conversation

ndimiduk commented Nov 29, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache9 commented Nov 30, 2021

taklwu Nov 30, 2021 • edited Loading

Choose a reason for hiding this comment

taklwu Nov 30, 2021

Choose a reason for hiding this comment

ndimiduk Nov 30, 2021

Choose a reason for hiding this comment

ndimiduk Nov 30, 2021

Choose a reason for hiding this comment

ndimiduk Nov 30, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

Apache-HBase commented Nov 30, 2021

ndimiduk commented Dec 1, 2021

taklwu Nov 30, 2021 •

edited

Loading