HBASE-22686 ZkSplitLogWorkerCoordination doesn't allow a regionserver to pick up all of the split work it is capable of #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurtell
force-pushed
the
HBASE-22686
branch
2 times, most recently
from
4106107 to
5c0b3d9
Compare
|
Updated to remove now invalid unit test. |
|
Latest change moves debug log lines to TRACE level which might otherwise be logged 10 times a second. |
… to pick up all of the split work it is capable of
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2019
… to pick up all of the split work it is capable of (#377) Signed-off-by: Xu Cang <[email protected]>
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2019
… to pick up all of the split work it is capable of (#377) Signed-off-by: Xu Cang <[email protected]> Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitLogWorker.java
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2019
… to pick up all of the split work it is capable of (#377) Signed-off-by: Xu Cang <[email protected]>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
… to pick up all of the split work it is capable of (apache#377) Signed-off-by: Xu Cang <[email protected]>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
… to pick up all of the split work it is capable of (apache#377) Signed-off-by: Xu Cang <[email protected]> (cherry picked from commit c2f7093) Change-Id: Ieb35564babee99965e4fc4a87fd8a1c9b7d37f0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regionserver side distributed split coordination logic only allows a regionserver to grab one task one at a time. Nearby javadoc says "This policy puts an upper-limit on the number of simultaneous log splitting that could be happening in a cluster." That upper limit will be the number of currently live regionservers. However, a regionserver can handle more than one task at once and in fact the max number of concurrent split tasks it can accept is configurable.