Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-21606 document meta table load metrics #369

Closed
wants to merge 3 commits into from
Closed

HBASE-21606 document meta table load metrics #369

wants to merge 3 commits into from

Conversation

symat
Copy link
Contributor

@symat symat commented Jul 9, 2019

I also attached a screenshot in jira (to see the formatting): HBASE-21606-v1.png

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 28 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
_ master Compile Tests _
+1 mvninstall 266 master passed
0 refguide 475 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 mvninstall 237 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
0 refguide 482 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 asflicense 14 The patch does not generate ASF License warnings.
1568
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/Dockerfile
GITHUB PR #369
Optional Tests dupname asflicense refguide
uname Linux 4ddc4bc5658f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 9ac9505
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@busbey
Copy link
Contributor

busbey commented Jul 9, 2019

here's the new section in the rendering the QA bot did: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/1/artifact/out/patch-site/book.html#rs_meta_metrics

busbey
busbey requested changes Jul 9, 2019
View reviewed changes
src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved
xcangCRM
xcangCRM approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@xcangCRM xcangCRM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.
In general, the content is accurate.
Please address some grammar issues pointed by Sean. Thanks!

src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved
xcangCRM
xcangCRM reviewed Jul 9, 2019
View reviewed changes
src/main/asciidoc/_chapters/ops_mgt.adoc
[[rs_meta_metrics]]
=== Meta Table Load Metrics

HBase meta table metrics collection feature is available in HBase 1.4+ but it is disabled by default, as it can
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's available since 1.3
Could you please double check that? thanks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I just checked it. I don't find the MetaTableMetrics coprocessor or the lossy counting related config parameter in 1.3.
Also the whole metrics system was changed between 1.3 and 1.4 (you don't have the hbase-metrics maven module in 1.3), I guess this is why it wasn't merged back from 1.4.

@xcangCRM xcangCRM self-requested a review July 9, 2019 18:28
the-sakthi
the-sakthi reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@the-sakthi the-sakthi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. Other than that, the update looks great! Thanks @symat

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 142 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
_ master Compile Tests _
+1 mvninstall 315 master passed
0 refguide 853 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 mvninstall 344 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
0 refguide 566 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 asflicense 17 The patch does not generate ASF License warnings.
2305
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/Dockerfile
GITHUB PR #369
Optional Tests dupname asflicense refguide
uname Linux ec5316c571e6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 438bf32
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/artifact/out/patch-site/book.html
Max. process+thread count 86 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi
Copy link
Member

+1. Thanks @symat

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 33 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
_ master Compile Tests _
+1 mvninstall 255 master passed
0 refguide 465 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Patch Compile Tests _
+1 mvninstall 244 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
0 refguide 438 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
_ Other Tests _
+1 asflicense 16 The patch does not generate ASF License warnings.
1507
Subsystem Report/Notes
Docker Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/Dockerfile
GITHUB PR #369
Optional Tests dupname asflicense refguide
uname Linux 6d1511253183 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 74731c2
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/branch-site/book.html
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/artifact/out/patch-site/book.html
Max. process+thread count 96 (vs. ulimit of 10000)
modules C: . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-369/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@asfgit asfgit closed this in e5f05bf Jul 15, 2019
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
1340706 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
5f8c0fc 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
fc250f5 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
930e888 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
4211266 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
asfgit pushed a commit that referenced this pull request Jul 15, 2019
@symat @busbey
HBASE-21606 document meta table load metrics
10d2499 
Closes #369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
symat added a commit to symat/hbase that referenced this pull request Feb 17, 2021
@symat
HBASE-21606 document meta table load metrics
ebeaddf 
Closes apache#369

Signed-off-by: Xu Cang <[email protected]>
Signed-off-by: Sakthi <[email protected]>
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit e5f05bf)
(cherry picked from commit 10d2499)

Change-Id: I575556cec560378f0a1057f8ad604ed4b17d7968
@wchevreuil wchevreuil mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-sakthi the-sakthi the-sakthi approved these changes

@busbey busbey busbey approved these changes

@xcangCRM xcangCRM Awaiting requested review from xcangCRM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@symat @Apache-HBase @busbey @the-sakthi @xcangCRM