HBASE-25881: Create a chore to update age related metrics #3518
+218
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Still have to look into test failure. @shahrs87 @anoopsjohn wondering if you guys can have a look and provide feedback about the approach if any. Thanks |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@virajjasani @apurtell @anoopsjohn Looking for review on this PR. Thanks |
anoopsjohn
reviewed
Aug 2, 2021
| */ | ||
| @InterfaceAudience.Private | ||
| @InterfaceStability.Evolving | ||
| public class MetricsReplicationSourceRefresherChore extends ScheduledChore { |
There was a problem hiding this comment.
ReplicationSourceMetricsRefresherChore a better name?
| */ | ||
| private long getOldestWalTimestamp() { | ||
| long oldestWalTimestamp = Long.MAX_VALUE; | ||
| for (Map.Entry<String, PriorityBlockingQueue<Path>> entry : this.replicationSource.getQueues() |
|
|
||
| private MetricsSource metrics; | ||
|
|
||
| public static final String DURATION = "hbase.metrics.replication.source.refresher.duration"; |
There was a problem hiding this comment.
Here also..
better name would be hbase.replication.source.metrics.refresher.duration
Or even
hbase.replication.source.metrics.refresher.period ?
shahrs87
requested changes
Aug 3, 2021
| public class MetricsReplicationSourceRefresherChore extends ScheduledChore { | ||
|
|
||
| private ReplicationSource replicationSource; | ||
|
|
| @@ -224,6 +224,10 @@ public void init(Configuration conf, FileSystem fs, ReplicationSourceManager man | |||
| this.abortOnError = this.conf.getBoolean("replication.source.regionserver.abort", | |||
| true); | |||
|
|
|||
| int duration = this.conf.getInt(MetricsReplicationSourceRefresherChore.DURATION, | |||
There was a problem hiding this comment.
Are we creating a chore for every replication source ? If we have 2-3 peers, this will create that many chores. Instead is it possible to create just 1 chore and initialize with ReplicationSourceManager which has list of all replicationSources and just iterate over them every time this chore wakes up. Thoughts ?
| /* | ||
| * Returns the age of oldest wal. | ||
| */ | ||
| long getOldestWalAge() { |
There was a problem hiding this comment.
@rahulLiving There are many age related metrics in Replication subsytem. We want to update all the metrics from this Chore. I don't think it is a good idea to move the implementation from ReplicationSourceLogQueue to here.
What I had in my mind is: Compute oldestWalTimestamp (not the age, just the timestamp) in ReplicationSourceLogQueue and keep it as a class variable. Don't calculate the age there. Instead calculate the age in this chore. So for some reason if Replication thread is stuck, it will not update oldestWalTimestamp and since age is calculated in this chore, it will be updated. Does that make sense ?
| @@ -662,12 +666,16 @@ public void testAgeOfOldestWal() throws Exception { | |||
| manualEdge.setValue(10); | |||
| // Diff of current time (10) and log-walgroup-a.8 timestamp will be 2. | |||
| source.enqueueLog(log1); | |||
| // Sleep for chore to update WAL age | |||
| Thread.sleep(1000); | |||
There was a problem hiding this comment.
Use Waiter.waitFor method to wait on some condition. That way if the jenkins machine are slow, it will not create flaky tests.
|
@rahulLiving Checking whether you are still interested in working on this patch ? If not, then I can carry forward the work that you have done until now. Thank you ! |
|
Hi @shahrs87 , sorry about not being able to prioritise the above review comments. Unfortunately, won't be able to focus on this PR for current month at least. Please feel free to take it up if this has to be prioritised. Thanks |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.