Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22645: Backport HBASE-19893-restore_snapshot is broken in maste… #349

Closed
wants to merge 1 commit into from

Conversation

the-sakthi
Copy link
Member

…r branch when region splits

@the-sakthi
Copy link
Member Author

@Apache9 This change reverts some parts of the addendum that was added to fix UT failures after HBASE-21310 & HBASE-21311.

Also, @brfrn169 can I get your review here!

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 172 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 4 new or modified test files.
_ branch-2.1 Compile Tests _
+1 mvninstall 304 branch-2.1 passed
+1 compile 66 branch-2.1 passed
+1 checkstyle 93 branch-2.1 passed
+1 shadedjars 304 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 169 branch-2.1 passed
+1 javadoc 40 branch-2.1 passed
_ Patch Compile Tests _
+1 mvninstall 294 the patch passed
+1 compile 68 the patch passed
+1 javac 68 the patch passed
+1 checkstyle 95 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 302 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 1199 Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2.
+1 findbugs 171 the patch passed
+1 javadoc 40 the patch passed
_ Other Tests _
-1 unit 13750 hbase-server in the patch failed.
+1 asflicense 30 The patch does not generate ASF License warnings.
17473
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/artifact/out/Dockerfile
GITHUB PR #349
JIRA Issue HBASE-22645
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux af09c57dc0f3 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-2.1 / 963cb45
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/testReport/
Max. process+thread count 4846 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@brfrn169
Copy link
Member

brfrn169 commented Jul 2, 2019

+1 LGTM. And it looks like the failed tests in the last QA is unrelated to the patch.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 7 #349 does not apply to branch-2.1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #349
JIRA Issue HBASE-22645
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-349/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@the-sakthi
Copy link
Member Author

The patch went in already in JIRA. Closing this PR

@the-sakthi the-sakthi closed this Jul 12, 2019
@the-sakthi the-sakthi deleted the hbase-22645 branch July 12, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants