HBASE-26021: Undo the incompatible serialization change in HBASE-7767

[bharathv]

Revert "HBASE-7767 Get rid of ZKTable, and table enable/disable state in ZK (Andrey Stepachev)"

Fixes the ConnectionRegistry and dependencies due to the revert.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	7m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 1s	The patch appears to include 25 new or modified test files.
		_ branch-1 Compile Tests _
+0 🆗	mvndep	2m 29s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 9s	branch-1 passed
+1 💚	compile	1m 50s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	2m 2s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	6m 29s	branch-1 passed
+1 💚	shadedjars	3m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 33s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 37s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	2m 47s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 28s	branch-1 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 58s	the patch passed
+1 💚	compile	1m 49s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	cc	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	compile	2m 3s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	cc	2m 3s	the patch passed
+1 💚	javac	2m 3s	the patch passed
-1 ❌	checkstyle	0m 45s	hbase-client: The patch generated 21 new + 446 unchanged - 2 fixed = 467 total (was 448)
-1 ❌	checkstyle	2m 13s	hbase-server: The patch generated 53 new + 1841 unchanged - 92 fixed = 1894 total (was 1933)
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌	whitespace	0m 0s	The patch 1 line(s) with tabs.
+1 💚	shadedjars	3m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 41s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	hbaseprotoc	2m 14s	the patch passed
+1 💚	javadoc	1m 19s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 40s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	findbugs	7m 53s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 28s	hbase-protocol in the patch passed.
+1 💚	unit	2m 40s	hbase-client in the patch passed.
+1 💚	unit	143m 13s	hbase-server in the patch passed.
+1 💚	unit	11m 52s	hbase-rsgroup in the patch passed.
+1 💚	asflicense	1m 47s	The patch does not generate ASF License warnings.
		241m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/artifact/out/Dockerfile
GITHUB PR	#3435
JIRA Issue	HBASE-26021
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux bf5e358b5983 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3435/out/precommit/personality/provided.sh
git revision	branch-1 / 395eb0c
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/artifact/out/whitespace-eol.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/artifact/out/whitespace-tabs.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/testReport/
Max. process+thread count	4462 (vs. ulimit of 10000)
modules	C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/1/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

Skimmed, seems good and QA is happy so should be good.
nit: is it possible to provide 2 commits in this PR:

1. revert TableDescriptor commit
2. make MasterRegistry work with commit 1

It's fine if not possible.

[virajjasani]

+1 since QA has no objections in tests.

[bharathv]

Is it possible to provide 2 commits in this PR:

I clubbed them into a single commit unfortunately but would've been better if I did them as separate commits for reviews. Most code should be around TableState stuff in ConnectionRegistry interface.

Let me add some more test coverage for the interface methods before I commit.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 2s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 25 new or modified test files.
		_ branch-1 Compile Tests _
+0 🆗	mvndep	2m 28s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 4s	branch-1 passed
+1 💚	compile	1m 46s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	2m 1s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	6m 13s	branch-1 passed
+1 💚	shadedjars	3m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 32s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 37s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	2m 54s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 45s	branch-1 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 58s	the patch passed
+1 💚	compile	1m 48s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	cc	1m 48s	the patch passed
+1 💚	javac	1m 48s	the patch passed
+1 💚	compile	2m 1s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	cc	2m 1s	the patch passed
+1 💚	javac	2m 1s	the patch passed
-1 ❌	checkstyle	0m 47s	hbase-client: The patch generated 11 new + 447 unchanged - 1 fixed = 458 total (was 448)
-1 ❌	checkstyle	2m 15s	hbase-server: The patch generated 46 new + 1841 unchanged - 92 fixed = 1887 total (was 1933)
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedjars	2m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 50s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	hbaseprotoc	2m 20s	the patch passed
+1 💚	javadoc	1m 20s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 43s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	findbugs	8m 6s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 28s	hbase-protocol in the patch passed.
+1 💚	unit	2m 43s	hbase-client in the patch passed.
+1 💚	unit	140m 3s	hbase-server in the patch passed.
+1 💚	unit	14m 13s	hbase-rsgroup in the patch passed.
+1 💚	asflicense	1m 53s	The patch does not generate ASF License warnings.
		234m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/artifact/out/Dockerfile
GITHUB PR	#3435
JIRA Issue	HBASE-26021
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux 0dd0e2178cdc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3435/out/precommit/personality/provided.sh
git revision	branch-1 / 395eb0c
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/artifact/out/whitespace-eol.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/testReport/
Max. process+thread count	4138 (vs. ulimit of 10000)
modules	C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/2/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

[bharathv]

Most checkstyle issues are from the original implementation, too many to even fix. Leaving them as-is. Will wait for one final jenkins run before merging.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	6m 53s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+0 🆗	prototool	0m 0s	prototool was not available.
+1 💚	hbaseanti	0m 1s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 26 new or modified test files.
		_ branch-1 Compile Tests _
+0 🆗	mvndep	2m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	8m 5s	branch-1 passed
+1 💚	compile	1m 46s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	compile	1m 59s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	checkstyle	6m 6s	branch-1 passed
+1 💚	shadedjars	3m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 29s	branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 40s	branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗	spotbugs	2m 42s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	7m 19s	branch-1 passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 51s	the patch passed
+1 💚	compile	1m 42s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	cc	1m 42s	the patch passed
+1 💚	javac	1m 42s	the patch passed
+1 💚	compile	2m 1s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	cc	2m 1s	the patch passed
+1 💚	javac	2m 1s	the patch passed
-1 ❌	checkstyle	0m 47s	hbase-client: The patch generated 11 new + 447 unchanged - 1 fixed = 458 total (was 448)
-1 ❌	checkstyle	2m 24s	hbase-server: The patch generated 46 new + 1843 unchanged - 92 fixed = 1889 total (was 1935)
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedjars	2m 52s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	4m 29s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚	hbaseprotoc	2m 14s	the patch passed
+1 💚	javadoc	1m 18s	the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚	javadoc	1m 39s	the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚	findbugs	7m 50s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 29s	hbase-protocol in the patch passed.
+1 💚	unit	2m 45s	hbase-client in the patch passed.
+1 💚	unit	133m 34s	hbase-server in the patch passed.
+1 💚	unit	13m 56s	hbase-rsgroup in the patch passed.
+1 💚	asflicense	1m 52s	The patch does not generate ASF License warnings.
		232m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/artifact/out/Dockerfile
GITHUB PR	#3435
JIRA Issue	HBASE-26021
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc prototool
uname	Linux ed0806b1ec48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3435/out/precommit/personality/provided.sh
git revision	branch-1 / 395eb0c
Default Java	Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions	/usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/artifact/out/diff-checkstyle-hbase-client.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/artifact/out/diff-checkstyle-hbase-server.txt
whitespace	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/artifact/out/whitespace-eol.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/testReport/
Max. process+thread count	4704 (vs. ulimit of 10000)
modules	C: hbase-protocol hbase-client hbase-server hbase-rsgroup U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3435/3/console
versions	git=1.9.1 maven=3.0.5 findbugs=3.0.1
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.