HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable #3298

wchevreuil · 2021-05-24T15:34:50Z

We need this to conduct other tasks related to flush without renames.

Change-Id: I7963a0dc65033515c1baeb4a4302f80765153635

Apache-HBase · 2021-05-24T16:29:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 9s	HBASE-24749 passed
+1 💚	compile	3m 34s	HBASE-24749 passed
+1 💚	checkstyle	1m 10s	HBASE-24749 passed
+1 💚	spotbugs	2m 20s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 7s	the patch passed
+1 💚	compile	3m 42s	the patch passed
+1 💚	javac	3m 42s	the patch passed
-0 ⚠️	checkstyle	1m 10s	hbase-server: The patch generated 10 new + 4 unchanged - 1 fixed = 14 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		53m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 92f4f230df49 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-24T18:28:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 30s	HBASE-24749 passed
+1 💚	compile	1m 15s	HBASE-24749 passed
+1 💚	shadedjars	8m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 43s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 13s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	8m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	140m 43s	hbase-server in the patch passed.
		172m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 657a40b7b90c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/testReport/
Max. process+thread count	4474 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-24T19:58:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 18s	HBASE-24749 passed
+1 💚	compile	1m 1s	HBASE-24749 passed
+1 💚	shadedjars	9m 0s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 6s	the patch passed
+1 💚	compile	1m 3s	the patch passed
+1 💚	javac	1m 3s	the patch passed
+1 💚	shadedjars	9m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	228m 58s	hbase-server in the patch passed.
		262m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e376b8dbdc40 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/testReport/
Max. process+thread count	3720 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

joshelser · 2021-05-24T20:14:00Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFlushContext.java

@@ -0,0 +1,183 @@
+/*
+ *


nit unnecessary line

joshelser · 2021-05-24T20:17:41Z

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java

+      return flushContextClass.getConstructor(HStore.class, Long.class, FlushLifeCycleTracker.class)
+        .newInstance(this, cacheFlushId, tracker);


Do you think it would be cleaner to move this into an init() method rather than using reflection on the constructor?

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFlushContext.java

Change-Id: I232a805e81e4ef0a85f980e2d1503f3cf4cfe204

joshelser

Talked to Wellington in chat -- he said that my ask to refactor the StoreFlushContext to use Store instead of HStore would be a quite a bit of work.

I do think that's a good thing to do long-term, but it's not the most urgent at this moment. I'm ok to defer that for now.

Apache-HBase · 2021-05-25T16:30:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	3m 59s	HBASE-24749 passed
+1 💚	compile	3m 10s	HBASE-24749 passed
+1 💚	checkstyle	1m 5s	HBASE-24749 passed
+1 💚	spotbugs	2m 4s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 35s	the patch passed
-1 ❌	compile	1m 22s	hbase-server in the patch failed.
-0 ⚠️	javac	1m 22s	hbase-server in the patch failed.
-0 ⚠️	checkstyle	1m 0s	hbase-server: The patch generated 12 new + 4 unchanged - 1 fixed = 16 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 9s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 19s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		45m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 0479cf901cdc 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-25T18:39:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 28s	HBASE-24749 passed
+1 💚	compile	1m 18s	HBASE-24749 passed
+1 💚	shadedjars	8m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 46s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 37s	the patch passed
+1 💚	compile	1m 22s	the patch passed
+1 💚	javac	1m 22s	the patch passed
+1 💚	shadedjars	8m 14s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	142m 37s	hbase-server in the patch passed.
		174m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b8a02b1bf48d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/testReport/
Max. process+thread count	4566 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-25T19:58:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 12s	HBASE-24749 passed
+1 💚	compile	1m 4s	HBASE-24749 passed
+1 💚	shadedjars	8m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 1s	the patch passed
+1 💚	compile	1m 5s	the patch passed
+1 💚	javac	1m 5s	the patch passed
+1 💚	shadedjars	9m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
-1 ❌	unit	221m 20s	hbase-server in the patch failed.
		253m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f3d5b6e667fd 4.15.0-142-generic #146-Ubuntu SMP Tue Apr 13 01:11:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/testReport/
Max. process+thread count	3096 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I492e59dd0b0f61fc4aebe9a020b4d2b679081ed5

Apache-HBase · 2021-05-26T11:08:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	3m 53s	HBASE-24749 passed
+1 💚	compile	3m 5s	HBASE-24749 passed
+1 💚	checkstyle	1m 4s	HBASE-24749 passed
+1 💚	spotbugs	2m 3s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
-1 ❌	compile	1m 23s	hbase-server in the patch failed.
-0 ⚠️	javac	1m 23s	hbase-server in the patch failed.
+1 💚	checkstyle	1m 0s	hbase-server: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 6s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 13s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		44m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 04f02c3988be 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
compile	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
Max. process+thread count	95 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: I8e66c65a5d32e583038ab2e6b75803934e2c0f63

Apache-HBase · 2021-05-26T13:23:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	3m 38s	HBASE-24749 passed
+1 💚	compile	1m 1s	HBASE-24749 passed
+1 💚	shadedjars	8m 14s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 41s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	8m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	149m 25s	hbase-server in the patch passed.
		178m 58s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 36cd031bda39 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/testReport/
Max. process+thread count	4624 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-26T14:34:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	5m 37s	HBASE-24749 passed
+1 💚	compile	1m 35s	HBASE-24749 passed
+1 💚	shadedjars	9m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 50s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 55s	the patch passed
+1 💚	compile	1m 34s	the patch passed
+1 💚	javac	1m 34s	the patch passed
+1 💚	shadedjars	9m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	211m 49s	hbase-server in the patch failed.
		249m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e1c93ac01db1 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/testReport/
Max. process+thread count	3294 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-26T15:22:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	3m 37s	HBASE-24749 passed
+1 💚	compile	3m 8s	HBASE-24749 passed
+1 💚	checkstyle	1m 2s	HBASE-24749 passed
+1 💚	spotbugs	2m 1s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 36s	the patch passed
+1 💚	compile	3m 4s	the patch passed
-0 ⚠️	javac	3m 4s	hbase-server generated 1 new + 192 unchanged - 1 fixed = 193 total (was 193)
+1 💚	checkstyle	1m 3s	hbase-server: The patch generated 0 new + 0 unchanged - 5 fixed = 0 total (was 5)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 10s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		46m 12s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux b0a9e39d130e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
javac	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-26T17:39:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 17s	HBASE-24749 passed
+1 💚	compile	0m 59s	HBASE-24749 passed
+1 💚	shadedjars	8m 7s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	8m 40s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	the patch passed
		_ Other Tests _
+1 💚	unit	151m 6s	hbase-server in the patch passed.
		182m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 10673e32e81f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/testReport/
Max. process+thread count	3748 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-26T18:39:30Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ HBASE-24749 Compile Tests _
+1 💚	mvninstall	4m 47s	HBASE-24749 passed
+1 💚	compile	1m 20s	HBASE-24749 passed
+1 💚	shadedjars	9m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	HBASE-24749 passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 48s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	shadedjars	8m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 41s	the patch passed
		_ Other Tests _
-1 ❌	unit	208m 25s	hbase-server in the patch failed.
		242m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3298
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 1760ebf222bd 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	HBASE-24749 / `77a2726`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/testReport/
Max. process+thread count	3368 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3298/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

wchevreuil · 2021-05-26T18:40:20Z

The previous UT failure was a flakey, have it passing locally.

HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable

e3295cf

Change-Id: I7963a0dc65033515c1baeb4a4302f80765153635

wchevreuil requested review from joshelser, apurtell, taklwu and Apache9 May 24, 2021 15:34

joshelser requested changes May 24, 2021

View reviewed changes

review comments

1fe44e6

Change-Id: I232a805e81e4ef0a85f980e2d1503f3cf4cfe204

joshelser approved these changes May 25, 2021

View reviewed changes

Fixing checkstyles

be72d4c

Change-Id: I492e59dd0b0f61fc4aebe9a020b4d2b679081ed5

Fixing yetus check

dc0a6ed

Change-Id: I8e66c65a5d32e583038ab2e6b75803934e2c0f63

wchevreuil merged commit a0c33de into apache:HBASE-24749 May 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable #3298

HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable #3298

wchevreuil commented May 24, 2021

Apache-HBase commented May 24, 2021

Apache-HBase commented May 24, 2021

Apache-HBase commented May 24, 2021

joshelser May 24, 2021

joshelser May 24, 2021

joshelser left a comment

Apache-HBase commented May 25, 2021

Apache-HBase commented May 25, 2021

Apache-HBase commented May 25, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

wchevreuil commented May 26, 2021

		return flushContextClass.getConstructor(HStore.class, Long.class, FlushLifeCycleTracker.class)
		.newInstance(this, cacheFlushId, tracker);

HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable #3298

HBASE-25907 Move StoreFlushContext out of HStore and make it pluggable #3298

Conversation

wchevreuil commented May 24, 2021

Apache-HBase commented May 24, 2021

Apache-HBase commented May 24, 2021

Apache-HBase commented May 24, 2021

joshelser May 24, 2021

Choose a reason for hiding this comment

joshelser May 24, 2021

Choose a reason for hiding this comment

joshelser left a comment

Choose a reason for hiding this comment

Apache-HBase commented May 25, 2021

Apache-HBase commented May 25, 2021

Apache-HBase commented May 25, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

Apache-HBase commented May 26, 2021

wchevreuil commented May 26, 2021